fix(js_formatter): fix SimpleArgument checks for call and member expressions #1057
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When I implemented some previous fixes for call argument grouping in #777, I made it use
SimpleArgument
, since that's the same thing Prettier does. I also expanded some of the things that it matched in #757, but there were still a few more things that were being decided on incorrectly:array[0]
, were not considered simple, because it only checked static member expressions.Math.floor(1 + 2)
.depth
.This PR addresses all of those errors and matches Prettier much more consistently in all of the cases I've checked.
Test Plan
Added a bunch of spec tests to cover most of the cases. There are plenty more that aren't covered, though, but they are covered by the normal simple_arguments tests.