fix(js_formatter): fix indention when huggable expressions break in arrow chains #1036
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I'm not sure if this came from some of the other fixes I'd made to arrow chains or was pre-existing and only came up because of those other fixes, but currently when a call argument layout with an arrow chain ends up using the middle variant (i.e., the signature chain is printed on a single line, but the body of the chain breaks), and the body is a huggable expression (i.e., an array, block body, jsx, etc.)), it gets printed with an extra level of indention:
This PR ensures that there is only a single level of indention for the tail body, matching Prettier's output.
Test Plan
There weren't any existing tests that hit this case, so I added them to the
arrow/currying.js
spec test.