Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 tsconfig.*.json not recognised, breaks formatting #4769

Closed
1 task done
hyperknot opened this issue Dec 21, 2024 · 1 comment
Closed
1 task done

🐛 tsconfig.*.json not recognised, breaks formatting #4769

hyperknot opened this issue Dec 21, 2024 · 1 comment
Assignees
Labels
L-JSON Language: JSON and super languages S-Bug-confirmed Status: report has been confirmed as a valid bug

Comments

@hyperknot
Copy link

hyperknot commented Dec 21, 2024

Environment information

CLI:
  Version:                      1.9.4
  Color support:                true

Platform:
  CPU Architecture:             aarch64
  OS:                           macos

Environment:
  BIOME_LOG_PATH:               unset
  BIOME_LOG_PREFIX_NAME:        unset
  BIOME_CONFIG_PATH:            unset
  NO_COLOR:                     unset
  TERM:                         "xterm-256color"
  JS_RUNTIME_VERSION:           "v20.17.0"
  JS_RUNTIME_NAME:              "node"
  NODE_PACKAGE_MANAGER:         unset

Biome Configuration:
  Status:                       Loaded successfully
  Formatter disabled:           false
  Linter disabled:              false
  Organize imports disabled:    false
  VCS disabled:                 false

Workspace:
  Open Documents:               0

What happened?

Biome breaks on tsconfig.node.json files when it contains comments.

Prettier gets this correctly.

Expected result

It should format it correctly, like prettier does.
As per the docs, it should recognise common config file formats and format accordingly.

Code of Conduct

  • I agree to follow Biome's Code of Conduct
@hyperknot hyperknot added the S-Needs triage Status: this issue needs to be triaged label Dec 21, 2024
@hyperknot hyperknot changed the title 🐛 tsconfig.*.json not recognised 🐛 tsconfig.*.json not recognised, breaks formatting Dec 21, 2024
@hyperknot
Copy link
Author

Related issue: #4769

I also paste this here:

Prettier also gets this one perfectly.

Basically prettier really gets JSON/JSONC formatting, without any config it just works. Both on comments in JSON, both on commas in JSONC, etc. Please take it as a reference implementation for JSON formatting and follow their defaults.

@dyc3 dyc3 added L-JSON Language: JSON and super languages S-Bug-confirmed Status: report has been confirmed as a valid bug labels Dec 21, 2024
@dyc3 dyc3 self-assigned this Dec 21, 2024
@github-actions github-actions bot removed the S-Needs triage Status: this issue needs to be triaged label Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L-JSON Language: JSON and super languages S-Bug-confirmed Status: report has been confirmed as a valid bug
Projects
None yet
Development

No branches or pull requests

3 participants