Skip to content

Commit

Permalink
fix: optional ARIA properties for role="separator" in `useAriaProps…
Browse files Browse the repository at this point in the history
…ForRole` (#3856)
  • Loading branch information
anthonyshew committed Sep 12, 2024
1 parent 39a820e commit dc2122e
Show file tree
Hide file tree
Showing 6 changed files with 85 additions and 148 deletions.
6 changes: 4 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,8 @@ our [guidelines for writing a good changelog entry](https://github.com/biomejs/b

- Fix edge case [#3791](https://github.com/biomejs/biome/issues/3791) for rule `noFocusedTests` being used with non-string-like expressions ([#3793](https://github.com/biomejs/biome/pull/3793)). Contributed by @h-a-n-a

- Fix optional ARIA properties for `role="separator"` in `useAriaPropsForRole` ([#3856](https://github.com/biomejs/biome/pull/3856)). Contributed by @anthonyshew

### Configuration

- Add support for loading configuration from `.editorconfig` files ([#1724](https://github.com/biomejs/biome/issues/1724)).
Expand Down Expand Up @@ -362,7 +364,7 @@ our [guidelines for writing a good changelog entry](https://github.com/biomejs/b

- [noConsole](https://biomejs.dev/linter/rules/no-console/) now accepts an option that specifies some allowed calls on `console`. Contributed by @Conaclos

- Add an `ignoreNull` option for [noDoubleEquals](https://biomejs.dev/linter/rules/no-double-equals/).
- Add an `ignoreNull` option for [noDoubleEquals](https://biomejs.dev/linter/rules/no-double-equals/).

By default the rule allows loose comparisons against `null`.
The option `ignoreNull` can be set to `false` for reporting loose comparison against `null`.
Expand Down Expand Up @@ -847,7 +849,7 @@ our [guidelines for writing a good changelog entry](https://github.com/biomejs/b

#### New features

- Add [noUnknownPseudoClass](https://biomejs.dev/linter/rules/no-unknown-pseudo-class/). Contributed by @tunamaguro
- Add [noUnknownPseudoClass](https://biomejs.dev/linter/rules/no-unknown-pseudo-class/). Contributed by @tunamaguro

#### Bug fixes

Expand Down
6 changes: 1 addition & 5 deletions crates/biome_aria/src/roles.rs
Original file line number Diff line number Diff line change
Expand Up @@ -152,11 +152,7 @@ define_role! {
define_role! {
/// https://www.w3.org/TR/wai-aria-1.1/#separator
SeparatorRole {
PROPS: [
("aria-valuemax", true),
("aria-valuemin", true),
("aria-valuenow", true),
],
PROPS: [],
ROLES: ["structure", "widget"],
CONCEPTS: &[("hr", &[])],
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,6 @@ var a = <span role="spinbutton" aria-valuemin="0" aria-valuemax="100"></span>;
var a = <span role="slider" aria-valuemin="0"></span>;
var a = <span role="slider" aria-valuemax="100"></span>;
var a = <span role="slider" aria-valuemin="0" aria-valuemax="100"></span>;
var a = <span role="separator" aria-valuemin="0"></span>;
var a = <span role="separator" aria-valuemax="100"></span>;
var a = <span role="separator" aria-valuemin="0" aria-valuemax="100"></span>;
var a = <span role="scrollbar" aria-valuemin="0"></span>;
var a = <span role="scrollbar" aria-valuemax="100"></span>;
var a = <span role="scrollbar" aria-valuemin="0" aria-valuemax="100"></span>;
Expand All @@ -21,4 +18,4 @@ var a = <span role="combobox"></span>;
var a = <span role="combobox" aria-expanded="true"></span>;
var a = <span role="combobox" aria-controls="true"></span>;
var a = <span role="menuitemcheckbox" ></span>;
var a = <span role="menuitemradio" ></span>;
var a = <span role="menuitemradio" ></span>;
Loading

0 comments on commit dc2122e

Please sign in to comment.