fix: check elseClause inside noUselessLoneBlockStatements (#584)

biomejs · Oct 23, 2023 · d420a7f · d420a7f
1 parent 926173a
commit d420a7f
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 2 deletions.
diff --git a/crates/biome_js_analyze/src/analyzers/nursery/no_useless_lone_block_statements.rs b/crates/biome_js_analyze/src/analyzers/nursery/no_useless_lone_block_statements.rs
@@ -7,8 +7,8 @@ use biome_console::markup;
 use biome_diagnostics::Applicability;
 use biome_js_factory::make;
 use biome_js_syntax::{
-    AnyJsStatement, JsBlockStatement, JsFileSource, JsLabeledStatement, JsStatementList,
-    JsVariableStatement,
+    AnyJsStatement, JsBlockStatement, JsElseClause, JsFileSource, JsLabeledStatement,
+    JsStatementList, JsVariableStatement,
 };
 use biome_rowan::{AstNode, AstNodeList, BatchMutationExt};
 
@@ -145,6 +145,12 @@ fn statement_has_block_level_declaration(statement: &AnyJsStatement, is_module:
 }
 
 fn in_control_structure(block: &JsBlockStatement) -> bool {
+    if let Some(node) = block.syntax().parent() {
+        let syntax_kind = node.kind();
+        if JsElseClause::can_cast(syntax_kind) {
+            return true;
+        }
+    }
     matches!(
         block.parent(),
         Some(

diff --git a/crates/biome_js_analyze/tests/specs/nursery/noUselessLoneBlockStatements/validModule.js b/crates/biome_js_analyze/tests/specs/nursery/noUselessLoneBlockStatements/validModule.js
@@ -51,4 +51,10 @@ function g() {
 
 {
  function foo() {}
+}
+
+if(x) {
+  x += 1;
+} else {
+  x += 2;
 }
diff --git a/crates/biome_js_analyze/tests/specs/nursery/noUselessLoneBlockStatements/validModule.js.snap b/crates/biome_js_analyze/tests/specs/nursery/noUselessLoneBlockStatements/validModule.js.snap
@@ -58,6 +58,12 @@ function g() {
 {
  function foo() {}
 }
+
+if(x) {
+  x += 1;
+} else {
+  x += 2;
+}
 ```