fix(lsp): update diagnostics only for supported files (#3741)

biomejs · Aug 30, 2024 · ca54036 · ca54036
1 parent bba3412
commit ca54036
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/crates/biome_lsp/src/handlers/text_document.rs b/crates/biome_lsp/src/handlers/text_document.rs
@@ -1,13 +1,12 @@
+use crate::utils::apply_document_changes;
+use crate::{documents::Document, session::Session};
 use anyhow::Result;
 use biome_service::workspace::{
     ChangeFileParams, CloseFileParams, DocumentFileSource, GetFileContentParams, OpenFileParams,
 };
 use tower_lsp::lsp_types;
 use tracing::{error, field};
 
-use crate::utils::apply_document_changes;
-use crate::{documents::Document, session::Session};
-
 /// Handler for `textDocument/didOpen` LSP notification
 #[tracing::instrument(
     level = "debug",

diff --git a/crates/biome_lsp/src/session.rs b/crates/biome_lsp/src/session.rs
@@ -318,6 +318,16 @@ impl Session {
             path: biome_path.clone(),
         })?;
 
+        if !file_features.supports_lint()
+            && !file_features.supports_organize_imports()
+            && !file_features.supports_assists()
+        {
+            self.client
+                .publish_diagnostics(url, vec![], Some(doc.version))
+                .await;
+            return Ok(());
+        }
+
         let diagnostics: Vec<Diagnostic> = {
             let mut categories = RuleCategoriesBuilder::default().with_syntax();
             if self.configuration_status().is_loaded() {