Skip to content

Commit

Permalink
fix(ci): missing codegen check (#3692)
Browse files Browse the repository at this point in the history
  • Loading branch information
Jayllyz authored Aug 21, 2024
1 parent d079e53 commit b690ee3
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 14 deletions.
1 change: 1 addition & 0 deletions .cargo/config.toml
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ codegen-bindings = "run -p xtask_codegen --features schema -- bindings"
codegen-configuration = "run -p xtask_codegen --features configuration -- configuration"
# updates a newly created crate
codegen-license = "run -p xtask_codegen --features license -- license"
codegen-migrate = "run -p xtask_codegen --features configuration -- migrate-eslint"
codegen-schema = "run -p xtask_codegen --features schema -- schema"
contributors = "run -p xtask_contributors --"
coverage = "run -p xtask_coverage --profile=release-with-debug --"
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/pull_request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,8 @@ jobs:
run: cargo codegen-schema
- name: Run the bindings codegen
run: cargo codegen-bindings
- name: Run the migrate codegen
run: cargo codegen-migrate
- name: Check for git diff
run: |
if [[ `git status --porcelain` ]]; then
Expand Down
12 changes: 0 additions & 12 deletions crates/biome_cli/src/execute/migrate/eslint_any_rule_to_biome.rs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions justfile
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ upgrade-tools:
gen-all:
cargo run -p xtask_codegen -- all
cargo codegen-configuration
cargo run -p xtask_codegen --features configuration -- migrate-eslint
cargo codegen-migrate
just gen-bindings
just format

Expand All @@ -35,7 +35,7 @@ gen-bindings:
gen-lint:
cargo run -p xtask_codegen -- analyzer
cargo codegen-configuration
cargo run -p xtask_codegen --features configuration -- migrate-eslint
cargo codegen-migrate
just gen-bindings
cargo run -p rules_check
just format
Expand Down

0 comments on commit b690ee3

Please sign in to comment.