fix(linter): fix typo in rule name. `useConsistentBuiltinInstatiation…

…` to `useConsistentBuiltinInstantiation` (#2662)
biomejs · May 1, 2024 · 773a735 · 773a735
1 parent e86df46
commit 773a735
Show file tree

Hide file tree

Showing 14 changed files with 73 additions and 68 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -25,6 +25,11 @@ our [guidelines for writing a good changelog entry](https://github.com/biomejs/b
 
 ### Linter
 
+#### Bug fixes
+
+- Fix typo by renaming `useConsistentBuiltinInstatiation` to `useConsistentBuiltinInstantiation`
+  Contributed by @minht11
+
 ### Parser
 
 
@@ -81,19 +86,19 @@ our [guidelines for writing a good changelog entry](https://github.com/biomejs/b
 
 #### New features
 
-- Add [nusery/noReactSpecificProps](https://biomejs.dev/linter/rules/no-react-specific-props/).
+- Add [nursery/noReactSpecificProps](https://biomejs.dev/linter/rules/no-react-specific-props/).
   Contributed by @marvin-j97
 
 - Add [noUselessUndefinedInitialization](https://biomejs.dev/linter/rules/no-useless-undefined-initialization/).
   Contributed by @lutaok
 
-- Add [nusery/useArrayLiterals](https://biomejs.dev/linter/rules/use-array-literals/).
+- Add [nursery/useArrayLiterals](https://biomejs.dev/linter/rules/use-array-literals/).
   Contributed by @Kazuhiro-Mimaki
 
-- Add [nusery/useConsistentBuiltinInstatiation](https://biomejs.dev/linter/rules/use-consistent-builtin-instatiation/).
+- Add [nursery/useConsistentBuiltinInstatiation](https://biomejs.dev/linter/rules/use-consistent-builtin-instantiation/).
   Contributed by @minht11
 
-- Add [nusery/useDefaultSwitchClause](https://biomejs.dev/linter/rules/use-default-switch-clause/).
+- Add [nursery/useDefaultSwitchClause](https://biomejs.dev/linter/rules/use-default-switch-clause/).
   Contributed by @michellocana
 
 #### Bug fixes

diff --git a/crates/biome_cli/src/execute/migrate/eslint_any_rule_to_biome.rs b/crates/biome_cli/src/execute/migrate/eslint_any_rule_to_biome.rs
diff --git a/crates/biome_configuration/src/linter/rules.rs b/crates/biome_configuration/src/linter/rules.rs
diff --git a/crates/biome_diagnostics_categories/src/categories.rs b/crates/biome_diagnostics_categories/src/categories.rs
@@ -134,7 +134,7 @@ define_categories! {
     "lint/nursery/noUselessUndefinedInitialization": "https://biomejs.dev/linter/rules/no-useless-undefined-initialization",
     "lint/nursery/noUnknownUnit": "https://biomejs.dev/linter/rules/no-unknown-unit",
     "lint/nursery/useBiomeSuppressionComment": "https://biomejs.dev/linter/rules/use-biome-suppression-comment",
-    "lint/nursery/useConsistentBuiltinInstatiation": "https://biomejs.dev/linter/rules/use-consistent-new-builtin",
+    "lint/nursery/useConsistentBuiltinInstantiation": "https://biomejs.dev/linter/rules/use-consistent-new-builtin",
     "lint/nursery/useGenericFontNames": "https://biomejs.dev/linter/rules/use-generic-font-names",
     "lint/nursery/useDefaultSwitchClause": "https://biomejs.dev/linter/rules/use-default-switch-clause",
     "lint/nursery/useImportRestrictions": "https://biomejs.dev/linter/rules/use-import-restrictions",

diff --git a/crates/biome_js_analyze/src/lint/correctness/no_invalid_new_builtin.rs b/crates/biome_js_analyze/src/lint/correctness/no_invalid_new_builtin.rs
@@ -52,11 +52,11 @@ declare_rule! {
     pub NoInvalidNewBuiltin {
         version: "1.3.0",
         name: "noInvalidNewBuiltin",
-        // TODO: Remove this source once `useConsistentBuiltinInstatiation` is stable
+        // TODO: Remove this source once `useConsistentBuiltinInstantiation` is stable
         sources: &[RuleSource::Eslint("no-new-native-nonconstructor")],
         recommended: true,
-        // TODO: Deprecate this source once `useConsistentBuiltinInstatiation` is stable
-        //deprecated: "Use the rule useConsistentBuiltinInstatiation instead.",
+        // TODO: Deprecate this source once `useConsistentBuiltinInstantiation` is stable
+        //deprecated: "Use the rule useConsistentBuiltinInstantiation instead.",
         fix_kind: FixKind::Unsafe,
     }
 }

diff --git a/crates/biome_js_analyze/src/lint/nursery.rs b/crates/biome_js_analyze/src/lint/nursery.rs
diff --git a/...ry/use_consistent_builtin_instatiation.rs → ...y/use_consistent_builtin_instantiation.rs b/...ry/use_consistent_builtin_instatiation.rs → ...y/use_consistent_builtin_instantiation.rs
@@ -97,9 +97,9 @@ declare_rule! {
     /// ]);
     /// ```
     ///
-    pub UseConsistentBuiltinInstatiation {
+    pub UseConsistentBuiltinInstantiation {
         version: "1.7.2",
-        name: "useConsistentBuiltinInstatiation",
+        name: "useConsistentBuiltinInstantiation",
         sources: &[
             RuleSource::EslintUnicorn("new-for-builtins"),
             RuleSource::Eslint("no-new-wrappers"),
@@ -111,9 +111,9 @@ declare_rule! {
     }
 }
 
-impl Rule for UseConsistentBuiltinInstatiation {
+impl Rule for UseConsistentBuiltinInstantiation {
     type Query = Semantic<JsNewOrCallExpression>;
-    type State = UseConsistentBuiltinInstatiationState;
+    type State = UseConsistentBuiltinInstantiationState;
     type Signals = Option<Self::State>;
     type Options = ();
 
@@ -130,7 +130,7 @@ impl Rule for UseConsistentBuiltinInstatiation {
             .is_ok()
         {
             return ctx.model().binding(&reference).is_none().then_some(
-                UseConsistentBuiltinInstatiationState {
+                UseConsistentBuiltinInstantiationState {
                     name: name_text.to_string(),
                     creation_rule,
                 },
@@ -249,7 +249,7 @@ impl BuiltinCreationRule {
     }
 }
 
-pub struct UseConsistentBuiltinInstatiationState {
+pub struct UseConsistentBuiltinInstantiationState {
     name: String,
     creation_rule: BuiltinCreationRule,
 }

diff --git a/crates/biome_js_analyze/src/options.rs b/crates/biome_js_analyze/src/options.rs
@@ -260,7 +260,7 @@ pub type UseButtonType =
 pub type UseCollapsedElseIf =
     <lint::style::use_collapsed_else_if::UseCollapsedElseIf as biome_analyze::Rule>::Options;
 pub type UseConsistentArrayType = < lint :: style :: use_consistent_array_type :: UseConsistentArrayType as biome_analyze :: Rule > :: Options ;
-pub type UseConsistentBuiltinInstatiation = < lint :: nursery :: use_consistent_builtin_instatiation :: UseConsistentBuiltinInstatiation as biome_analyze :: Rule > :: Options ;
+pub type UseConsistentBuiltinInstantiation = < lint :: nursery :: use_consistent_builtin_instantiation :: UseConsistentBuiltinInstantiation as biome_analyze :: Rule > :: Options ;
 pub type UseConst = <lint::style::use_const::UseConst as biome_analyze::Rule>::Options;
 pub type UseDefaultParameterLast = < lint :: style :: use_default_parameter_last :: UseDefaultParameterLast as biome_analyze :: Rule > :: Options ;
 pub type UseDefaultSwitchClause = < lint :: nursery :: use_default_switch_clause :: UseDefaultSwitchClause as biome_analyze :: Rule > :: Options ;

diff --git a/...eConsistentBuiltinInstatiation/invalid.js → ...ConsistentBuiltinInstantiation/invalid.js b/...eConsistentBuiltinInstatiation/invalid.js → ...ConsistentBuiltinInstantiation/invalid.js