fix(lint/useExhaustiveDeps): handle hook source (#578) (#996)

crates/biome_js_analyze/src/react/hooks.rs

@@ -209,6 +209,7 @@ impl StableReactHookConfiguration {
 /// ```
 pub fn is_binding_react_stable(
     binding: &AnyJsIdentifierBinding,
+    model: &SemanticModel,
     stable_config: &FxHashSet<StableReactHookConfiguration>,
 ) -> bool {
     fn array_binding_declarator_index(
@@ -232,26 +233,22 @@ pub fn is_binding_react_stable(
     array_binding_declarator_index(binding)
         .or_else(|| assignment_declarator(binding))
         .and_then(|(declarator, index)| {
-            let hook_name = declarator
+            let callee = declarator
                 .initializer()?
                 .expression()
                 .ok()?
                 .as_js_call_expression()?
                 .callee()
-                .ok()?
-                .as_js_identifier_expression()?
-                .name()
-                .ok()?
-                .value_token()
-                .ok()?
-                .token_text_trimmed();
+                .ok()?;
 
-            let stable = StableReactHookConfiguration {
-                hook_name: hook_name.to_string(),
-                index,
-            };
-
-            Some(stable_config.contains(&stable))
+            Some(stable_config.iter().any(|config| {
+                is_react_call_api(
+                    callee.clone(),
+                    model,
+                    ReactLibrary::React,
+                    &config.hook_name,
+                ) && index == config.index
+            }))
         })
         .unwrap_or(false)
 }
@@ -260,12 +257,46 @@ pub fn is_binding_react_stable(
 mod test {
     use super::*;
     use biome_js_parser::JsParserOptions;
+    use biome_js_semantic::{semantic_model, SemanticModelOptions};
     use biome_js_syntax::JsFileSource;
 
     #[test]
     pub fn ok_react_stable_captures() {
         let r = biome_js_parser::parse(
-            "const ref = useRef();",
+            r#"
+                import { useRef } from "react";
+                const ref = useRef();
+            "#,
+            JsFileSource::js_module(),
+            JsParserOptions::default(),
+        );
+        let node = r
+            .syntax()
+            .descendants()
+            .filter(|x| x.text_trimmed() == "ref")
+            .last()
+            .unwrap();
+        let set_name = AnyJsIdentifierBinding::cast(node).unwrap();
+
+        let config = FxHashSet::from_iter([
+            StableReactHookConfiguration::new("useRef", None),
+            StableReactHookConfiguration::new("useState", Some(1)),
+        ]);
+
+        assert!(is_binding_react_stable(
+            &set_name,
+            &semantic_model(&r.ok().unwrap(), SemanticModelOptions::default()),
+            &config
+        ));
+    }
+
+    #[test]
+    pub fn ok_react_stable_captures_with_default_import() {
+        let r = biome_js_parser::parse(
+            r#"
+                import * as React from "react";
+                const ref = React.useRef();
+            "#,
             JsFileSource::js_module(),
             JsParserOptions::default(),
         );
@@ -282,6 +313,10 @@ mod test {
             StableReactHookConfiguration::new("useState", Some(1)),
         ]);
 
-        assert!(is_binding_react_stable(&set_name, &config));
+        assert!(is_binding_react_stable(
+            &set_name,
+            &semantic_model(&r.ok().unwrap(), SemanticModelOptions::default()),
+            &config
+        ));
     }
 }

crates/biome_js_analyze/src/semantic_analyzers/correctness/use_exhaustive_dependencies.rs

@@ -120,7 +120,7 @@ declare_rule! {
     /// ```
     ///
     /// ```js
-    /// import { useEffect } from "react";
+    /// import { useEffect, useState } from "react";
     ///
     /// function component() {
     ///     const [name, setName] = useState();
@@ -472,7 +472,8 @@ fn capture_needs_to_be_in_the_dependency_list(
             }
 
             // ... they are assign to stable returns of another React function
-            let not_stable = !is_binding_react_stable(&binding.tree(), &options.stable_config);
+            let not_stable =
+                !is_binding_react_stable(&binding.tree(), model, &options.stable_config);
             not_stable.then_some(capture)
         }
 

crates/biome_js_analyze/tests/specs/correctness/useExhaustiveDependencies/missingDependenciesInvalid.js

@@ -1,5 +1,16 @@
 import React from "react";
-import { useEffect, useCallback, useMemo, useLayoutEffect, useInsertionEffect, useImperativeHandle } from "react";
+import {
+	useEffect,
+	useCallback,
+	useMemo,
+	useLayoutEffect,
+	useInsertionEffect,
+	useImperativeHandle,
+	useState,
+	useReducer,
+	useTransition,
+} from "react";
+import { useRef } from "preact/hooks"
 
 function MyComponent1() {
     let a = 1;
@@ -123,3 +134,22 @@ function MyComponent13() {
       console.log(a);
   }, []);
 }
+
+// imports from other libraries
+function MyComponent14() {
+	const ref = useRef();
+	useEffect(() => {
+			console.log(ref.current);
+	}, []);
+}
+
+// local overrides
+function MyComponent15() {
+	const useRef = () => {
+		return { current: 1 }
+	}
+	const ref = useRef();
+	useEffect(() => {
+			console.log(ref.current);
+	}, []);
+}