feat(biome_graphql_parser): parse object extension (#2928)

crates/biome_graphql_parser/src/parser/definitions/mod.rs

@@ -25,7 +25,7 @@ use self::{
     fragment::parse_fragment_definition,
     input_object::parse_input_object_type_definition,
     interface::parse_interface_type_definition,
-    object::parse_object_type_definition,
+    object::{parse_object_type_definition, parse_object_type_extension},
     operation::{parse_operation_definition, parse_selection_set},
     r#enum::parse_enum_type_definition,
     scalar::{parse_scalar_type_definition, parse_scalar_type_extension},
@@ -98,6 +98,7 @@ fn parse_extension(p: &mut GraphqlParser) -> ParsedSyntax {
     match p.nth(1) {
         T![schema] => parse_schema_extension(p),
         T![scalar] => parse_scalar_type_extension(p),
+        T![type] => parse_object_type_extension(p),
         _ => Absent,
     }
 }

crates/biome_graphql_parser/src/parser/definitions/object.rs

@@ -1,10 +1,13 @@
 use crate::parser::{
-    directive::DirectiveList, parse_description, parse_error::expected_name, parse_name,
-    GraphqlParser,
+    directive::DirectiveList,
+    parse_description,
+    parse_error::{expected_name, expected_object_extension},
+    parse_name, GraphqlParser,
 };
 use biome_graphql_syntax::{GraphqlSyntaxKind::*, T};
 use biome_parser::{
-    parse_lists::ParseNodeList, parsed_syntax::ParsedSyntax, prelude::ParsedSyntax::*, Parser,
+    parse_lists::ParseNodeList, parsed_syntax::ParsedSyntax, prelude::ParsedSyntax::*,
+    token_source::TokenSource, Parser,
 };
 
 use super::{field::parse_fields_definition, interface::parse_implements_interface};
@@ -29,3 +32,28 @@ pub(crate) fn parse_object_type_definition(p: &mut GraphqlParser) -> ParsedSynta
 
     Present(m.complete(p, GRAPHQL_OBJECT_TYPE_DEFINITION))
 }
+
+/// Must only be called if the next 2 token is `extend` and `type`, otherwise it will panic.
+#[inline]
+pub(crate) fn parse_object_type_extension(p: &mut GraphqlParser) -> ParsedSyntax {
+    let m = p.start();
+
+    p.bump(T![extend]);
+    p.bump(T![type]);
+
+    parse_name(p).or_add_diagnostic(p, expected_name);
+
+    let implements_interface_empty = parse_implements_interface(p).is_absent();
+
+    let pos = p.source().position();
+    DirectiveList.parse_list(p);
+    let directive_empty = p.source().position() == pos;
+
+    let fields_definition_empty = parse_fields_definition(p).is_absent();
+
+    if directive_empty && implements_interface_empty && fields_definition_empty {
+        p.error(expected_object_extension(p, p.cur_range()));
+    }
+
+    Present(m.complete(p, GRAPHQL_OBJECT_TYPE_EXTENSION))
+}

crates/biome_graphql_parser/src/parser/definitions/scalar.rs

@@ -24,6 +24,7 @@ pub(crate) fn parse_scalar_type_definition(p: &mut GraphqlParser) -> ParsedSynta
     Present(m.complete(p, GRAPHQL_SCALAR_TYPE_DEFINITION))
 }
 
+/// Must only be called if the next 2 token is `extend` and `scalar`, otherwise it will panic.
 #[inline]
 pub(crate) fn parse_scalar_type_extension(p: &mut GraphqlParser) -> ParsedSyntax {
     let m = p.start();

crates/biome_graphql_parser/src/parser/definitions/schema.rs

@@ -33,6 +33,7 @@ pub(crate) fn parse_schema_definition(p: &mut GraphqlParser) -> ParsedSyntax {
     Present(m.complete(p, GRAPHQL_SCHEMA_DEFINITION))
 }
 
+/// Must only be called if the next 2 token is `extend` and `schema`, otherwise it will panic.
 #[inline]
 pub(crate) fn parse_schema_extension(p: &mut GraphqlParser) -> ParsedSyntax {
     let m = p.start();

crates/biome_graphql_parser/src/parser/parse_error.rs

@@ -13,12 +13,12 @@ pub(crate) fn expected_any_selection(p: &GraphqlParser, range: TextRange) -> Par
     expected_any(&["field", "fragment spread", "inline fragment"], range, p)
 }
 
-pub(crate) fn expected_name(p: &GraphqlParser, range: TextRange) -> ParseDiagnostic {
-    expected_node("name", range, p)
+pub(crate) fn fragment_name_must_not_be_on(p: &GraphqlParser, range: TextRange) -> ParseDiagnostic {
+    p.err_builder("Fragment name must not be 'on'", range)
 }
 
-pub(crate) fn expected_directive(p: &GraphqlParser, range: TextRange) -> ParseDiagnostic {
-    expected_node("directive", range, p)
+pub(crate) fn expected_name(p: &GraphqlParser, range: TextRange) -> ParseDiagnostic {
+    expected_node("name", range, p)
 }
 
 pub(crate) fn expected_named_type(p: &GraphqlParser, range: TextRange) -> ParseDiagnostic {
@@ -63,6 +63,7 @@ pub(crate) fn expected_schema_extension(p: &GraphqlParser, range: TextRange) ->
         range,
     )
 }
+
 pub(crate) fn expected_root_operation_type_definition(
     p: &GraphqlParser,
     range: TextRange,
@@ -74,6 +75,10 @@ pub(crate) fn expected_operation_type(p: &GraphqlParser, range: TextRange) -> Pa
     expected_any(&["query", "mutation", "subscription"], range, p)
 }
 
+pub(crate) fn expected_directive(p: &GraphqlParser, range: TextRange) -> ParseDiagnostic {
+    expected_node("directive", range, p)
+}
+
 pub(crate) fn expected_directive_location(p: &GraphqlParser, range: TextRange) -> ParseDiagnostic {
     p.err_builder("Expected a valid directive location", range)
         .with_alternatives(
@@ -102,6 +107,9 @@ pub(crate) fn expected_directive_location(p: &GraphqlParser, range: TextRange) -
         )
 }
 
-pub(crate) fn fragment_name_must_not_be_on(p: &GraphqlParser, range: TextRange) -> ParseDiagnostic {
-    p.err_builder("Fragment name must not be 'on'", range)
+pub(crate) fn expected_object_extension(p: &GraphqlParser, range: TextRange) -> ParseDiagnostic {
+    p.err_builder(
+        "Expected at least one directive, implements interface or fields definition",
+        range,
+    )
 }

crates/biome_graphql_parser/tests/graphql_test_suite/err/definitions/object_extension.graphql

@@ -0,0 +1,5 @@
+extend type Story
+
+extend type User
+  name: String
+}