fix: egression in useValidAutocomplete/valid.jsx.snap

biomejs · Jul 9, 2024 · 08adc60 · 08adc60
1 parent d6f4ad3
commit 08adc60
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/crates/biome_js_analyze/src/lint/nursery/use_valid_autocomplete.rs b/crates/biome_js_analyze/src/lint/nursery/use_valid_autocomplete.rs
@@ -165,6 +165,11 @@ impl Rule for UseValidAutocomplete {
                 let _initializer = autocomplete.initializer()?;
                 let extract_attrs = ctx.extract_attributes(&attributes)?;
                 let autocomplete_values = extract_attrs.get("autocomplete")?;
+                if let Some(f) = autocomplete_values.first() {
+                    if f == "[DYNAMIC]" || f == "none" {
+                        return None;
+                    }
+                }
                 if is_valid_autocomplete(autocomplete_values)? {
                     return None;
                 }
@@ -181,6 +186,11 @@ impl Rule for UseValidAutocomplete {
                 let _initializer = autocomplete.initializer()?;
                 let extract_attrs = ctx.extract_attributes(&attributes)?;
                 let autocomplete_values = extract_attrs.get("autocomplete")?;
+                if let Some(f) = autocomplete_values.first() {
+                    if f == "[DYNAMIC]" || f == "none" {
+                        return None;
+                    }
+                }
                 if is_valid_autocomplete(autocomplete_values)? {
                     return None;
                 }

diff --git a/crates/biome_js_analyze/src/services/aria.rs b/crates/biome_js_analyze/src/services/aria.rs
@@ -64,7 +64,7 @@ impl AriaServices {
                             .collect::<Vec<String>>()
                     } else {
                         // handle dynamic values e.g. `<div onClick={dynamicValue}>`
-                        vec![initializer.syntax().text_trimmed().to_string()]
+                        vec!["[DYNAMIC]".to_string()]
                     }
                 } else {
                     vec!["true".to_string()]