Skip to content

Commit

Permalink
Merge pull request #1 from djwhiteastro/master
Browse files Browse the repository at this point in the history
Updated README, tidied some code.
  • Loading branch information
djwhiteastro authored Dec 12, 2018
2 parents dcbad2f + d006019 commit 1080a8c
Show file tree
Hide file tree
Showing 3 changed files with 25 additions and 5 deletions.
Binary file added BioExcel_SeqQC.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
24 changes: 22 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ $ bioexcel_seqqc -h
An example of basic usage of the pipeline is:

```bash
$ bioexcel_seqqc --files in1.fa in2.fa --threads 4 --outdir ./output
$ bxcl_seqqc --files in1.fa in2.fa --threads 4 --outdir ./output
```

### Editing configuration for checkFastQC stage
Expand All @@ -74,7 +74,7 @@ changed. First, output an example configuration file (which contains the
default values):

```bash
$ bioexcel_seqqc --printconfig
$ bxcl_seqqc --printconfig
```

The file lists the summary outputs from FastQC, and what decisions to make
Expand Down Expand Up @@ -102,4 +102,24 @@ fqc.wait()

trim_process = rt.trimQC(infiles, trimdir, threads):
trim_process.wait()
```

## Stages

Our pipeline consists of three main stages: runfastqc, checkfastqc and runtrim.
Each stage exists as a python module as shown above. Each module contains
specific functions that execute the tools listed. The diagram below shows
each of these stages, with colour coding to show which tools are used in each
module, as well as useful output files. For this work, the module checkfastqc
was developed specifically to remove the human intervention required to check
output from fastqc before continuing with trimming/further analysis.

![alt text](./BioExcel_SeqQC.png "BioExcel_SeqQC workflow")

Each module can also be executed independently of the main executable workflow.
For example, if a situation occurs that causes cutadapt to fail, the runtrim
stage can be executed from the command line as

```bash
$ python -m bioexcel_align.runtrim <arguments>
```
6 changes: 3 additions & 3 deletions bioexcel_seqqc/checkfastqc.py
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,6 @@ def get_qc(fqcdir, passthrough, qcconf):
#qclist.append(splitline[0]) #Store Pass/Warn/Fail in list

# Check for dependance on 1st or 2nd pass through


print(qcpass, qtrim, atrim, recheck)
return qcpass, qtrim, atrim, recheck
Expand Down Expand Up @@ -114,8 +113,9 @@ def check_qc(infiles, fqcdir, trimdir, tmpdir, adaptseq, qcconf, threads,
if recheck:
### Will need work if logic changes to need retrim after pass 2
passthrough = 'pass2'

pfqc = rfqc.run_fqc([f1, f2], fqcdir+'/'+passthrough, tmpdir, threads)

pfqc = rfqc.run_fqc([f1, f2], fqcdir+'/'+passthrough, tmpdir,
threads)
pfqc.wait()
qcpass, qtrim, atrim, recheck = get_qc(fqcdir+'/'+passthrough,
passthrough, qcconf)
Expand Down

0 comments on commit 1080a8c

Please sign in to comment.