Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically resize main legend when changing tree coloring #512

Merged
merged 2 commits into from
May 4, 2021
Merged

Automatically resize main legend when changing tree coloring #512

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a5c9f5
ENH: auto resize main legend on changing
fedarko May 1, 2021
26f8202
MNT: move legend resizing to sep func
fedarko May 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions empress/support_files/css/empress.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -594,13 +594,20 @@ p.side-header button:hover,

/* The legend is resizable, thanks to resize: both; and overflow: auto.
* See https://stackoverflow.com/a/61976603/10730311.
*
* The 0.1px bottom padding prevents an unnecessary vertical scrollbar
* that kept showing up when setting the legend's width/height back to
* their defaults ("") in empress.js. It seems like having a tiny bit
* of extra vertical space is needed to get rid of this. It's barely
* visible to the user so it shouldn't be a problem.
*/
#legend-main {
margin: 20px;
min-width: 150px;
max-width: 33vw;
min-height: 30px;
max-height: 85vh;
padding-bottom: 0.1px;
resize: both;
overflow: auto;
background-color: rgba(255, 255, 255, 0.5);
Expand Down
15 changes: 15 additions & 0 deletions empress/support_files/js/empress.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2620,6 +2620,20 @@ define([
this._legend.clear();
};

/**
* Set the #legend-main width and height back to their defaults.
*
* This allows the legend to be resized back to whatever the default
* size will be, since manually resizing the legend sets a fixed
* width/height value.
*/
Empress.prototype.resizeLegend = function () {
// Setting CSS properties to "" causes the default values to be used:
// see https://stackoverflow.com/a/21457941.
document.getElementById("legend-main").style.width = "";
document.getElementById("legend-main").style.height = "";
};

/**
* Updates the legend based on a categorical color key.
*
Expand All @@ -2633,6 +2647,7 @@ define([
* color, expressed in hex format.
*/
Empress.prototype.updateLegendCategorical = function (name, keyInfo) {
this.resizeLegend();
this._legend.addCategoricalKey(name, keyInfo);
};

Expand Down