Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update breseq to v0.32.1 #9344

Closed
wants to merge 6 commits into from
Closed

Conversation

corburn
Copy link

@corburn corburn commented Jun 13, 2018

  • I have read the guidelines for bioconda recipes.
  • This PR adds a new recipe.
  • AFAIK, this recipe is directly relevant to the biological sciences (otherwise, please submit to the more general purpose conda-forge channel).
  • This PR updates an existing recipe.
  • This PR does something else (explain below).

@jerowe
Copy link
Contributor

jerowe commented Jun 14, 2018

libtool: compile:  g++ -DHAVE_CONFIG_H -I. -I../../../aux_build -O2 -std=c++11 -I../../../extern/samtools-1.3.1 -I../../../extern/samtools-1.3.1/htslib-1.3.1 -I../../../aux_build -DDATADIR=\"../share/breseq/\" -g -O2 -MT alignment.lo -MD -MP -MF .deps/alignment.Tpo -c alignment.cpp  -fPIC -DPIC -o .libs/alignment.o
In file included from ./libbreseq/storable.h:25:0,
                 from ./libbreseq/settings.h:24,
                 from libbreseq/fastq.h:23,
                 from libbreseq/alignment.h:25,
                 from alignment.cpp:19:
./libbreseq/json.hpp:67:10: error: #error "unsupported GCC version - see https://github.com/nlohmann/json#supported-compilers"
         #error "unsupported GCC version - see https://github.com/nlohmann/json#supported-compilers"
          ^
make[1]: *** [alignment.lo] Error 1
make[1]: Leaving directory `/opt/conda/conda-bld/breseq_1528903419845/work/breseq-0.32.1/src/c/breseq'

There are a few different ways you can deal with recipes that require samtools and co, and it depends on what the recipe needs.

If it needs to just link against the library you can include samtools as a build/runtime dep, and patch the makefile to tell it not to try and compile samtools.

If it needs some file from samtools/htslib distros that are not included in the conda package (it happens sometimes), you will have to go through, find all the makefiles for samtools and co, and make sure they match the makefiles in bioconda.

The first option is less painful and preferable when it can be used. ;-)

@jerowe
Copy link
Contributor

jerowe commented Jun 14, 2018

@jerowe
Copy link
Contributor

jerowe commented Jun 14, 2018

nlohmann/json#212

The json library this require is not compatible with gcc 4.8, which is what we have. I think this version of gcc has some backports that may fix whatever it doesn't like, so maybe add a patch to the json.hpp so that it won't throw that error? That is a total hack, but it may work.

@jerowe
Copy link
Contributor

jerowe commented Jun 14, 2018

Possibly patch libbreseq/json.hpp ?

./libbreseq/json.hpp:67:10: error: #error "unsupported GCC version - see https://github.com/nlohmann/json#supported-compilers"
         #error "unsupported GCC version - see https://github.com/nlohmann/json#supported-compilers"

@jerowe
Copy link
Contributor

jerowe commented Jun 14, 2018

This needs to be patched:

https://github.com/barricklab/breseq/blob/aa8f2595a244af15b721411475ba07bfa12c8634/src/c/breseq/libbreseq/json.hpp#L65

I think it might work with the linux-anvil gcc. It has some backports from 4.9 to fix stuff (I think).

@jerowe
Copy link
Contributor

jerowe commented Jun 16, 2018

just in time for conda build 3!

@corburn corburn mentioned this pull request Aug 1, 2018
5 tasks
@corburn corburn closed this Aug 1, 2018
@corburn corburn deleted the breseq_v0.32.1_14 branch August 1, 2018 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants