Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update - revert the change to noarch: python in meta.yaml for HybPiper version 2.1.7 #47860

Closed

Conversation

chrisjackson-pellicle
Copy link
Contributor

Reverting the change to noarch: python in the meta.yaml from the previous version bump pull request.

Although the HybPiper package is pure Python, the run dependency SPAdes prior to version 3.15.4 is incompatible with Python >3.9, see here and described here. The highest SPAdes version available as a osx-64 conda package is 3.15.2. This means that the osx-64 conda package for HybPiper is restricted to Python version 3.9 at the highest.

Although the Hybpiper package builds with noarch: python, it only installs via conda sucessfully on Linux. On macOS the user receives the error:

Could not solve for environment specs
The following package could not be installed
└─ hybpiper 2.1.7**  is not installable because it requires
   └─ spades >=3.15.4 , which does not exist (perhaps a missing channel).

Please read the guidelines for Bioconda recipes before opening a pull request (PR).

General instructions

  • If this PR adds or updates a recipe, use "Add" or "Update" appropriately as the first word in its title.
  • New recipes not directly relevant to the biological sciences need to be submitted to the conda-forge channel instead of Bioconda.
  • PRs require reviews prior to being merged. Once your PR is passing tests and ready to be merged, please issue the @BiocondaBot please add label command.
  • Please post questions on Gitter or ping @bioconda/core in a comment.

Instructions for avoiding API, ABI, and CLI breakage issues

Conda is able to record and lock (a.k.a. pin) dependency versions used at build time of other recipes.
This way, one can avoid that expectations of a downstream recipe with regards to API, ABI, or CLI are violated by later changes in the recipe.
If not already present in the meta.yaml, make sure to specify run_exports (see here for the rationale and comprehensive explanation).
Add a run_exports section like this:

build:
  run_exports:
    - ...

with ... being one of:

Case run_exports statement
semantic versioning {{ pin_subpackage("myrecipe", max_pin="x") }}
semantic versioning (0.x.x) {{ pin_subpackage("myrecipe", max_pin="x.x") }}
known breakage in minor versions {{ pin_subpackage("myrecipe", max_pin="x.x") }} (in such a case, please add a note that shortly mentions your evidence for that)
known breakage in patch versions {{ pin_subpackage("myrecipe", max_pin="x.x.x") }} (in such a case, please add a note that shortly mentions your evidence for that)
calendar versioning {{ pin_subpackage("myrecipe", max_pin=None) }}

while replacing "myrecipe" with either name if a name|lower variable is defined in your recipe or with the lowercase name of the package in quotes.

Bot commands for PR management

Please use the following BiocondaBot commands:

Everyone has access to the following BiocondaBot commands, which can be given in a comment:

@BiocondaBot please update Merge the master branch into a PR.
@BiocondaBot please add label Add the please review & merge label.
@BiocondaBot please fetch artifacts Post links to CI-built packages/containers.
You can use this to test packages locally.

Note that the @BiocondaBot please merge command is now depreciated. Please just squash and merge instead.

Also, the bot watches for comments from non-members that include @bioconda/<team> and will automatically re-post them to notify the addressed <team>.

@chrisjackson-pellicle
Copy link
Contributor Author

@BiocondaBot please add label

@BiocondaBot BiocondaBot added the please review & merge set to ask for merge label May 24, 2024
@bgruening
Copy link
Member

@chrisjackson-pellicle shouldn't we fix spades instead and create an OSX package for the latest version?

@chrisjackson-pellicle
Copy link
Contributor Author

Hi @bgruening - yes, that would be ideal, if possible. It looks like it's been tried unsuccessfully before, though. I think creating the packages using the pre-built binaries would work fine (e.g. as was done for SPAdes version 3.12), but apparently they can cause issues on some systems and compiling from source is recommended (see here and here).

I'll try again, merging patches 0001-change-verbosity.patch and 0002-spades-compile-remove-expr.patch .

@chrisjackson-pellicle
Copy link
Contributor Author

@bgruening SPAdes 3.15.15 builds appear to be ok! #48097

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
please review & merge set to ask for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants