-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new recipe mantis-msi2 #35843
Add new recipe mantis-msi2 #35843
Conversation
This is a fork of mantis-msi, as the latter version is no longer being maintained. mantis-msi2 includes fixes.
@BiocondaBot please fetch artifacts |
Package(s) built on Azure are ready for inspection:
You may also use
Docker image(s) built (images are in the LinuxArtifacts zip file above):
|
@BiocondaBot please add label |
Verified the OSX artifacts works for me locally |
@nh13 is upstream just not taking PRs or something? Or have the original authors documented that they will not maintain? The reason I as is that the changes in the fork seem pretty minor such that they could easily be incorporated to the original, which would save a little maintenance burden in bioconda and would be less confusing to users. |
@daler The original authors have not documented that they will not maintain. However, the upstream hasn't accepted a PR since Jan 23 2020, with the last response on a comment since Nov 6 2020. The person who merged that PR and made that last comment (rbonneville) hasn't had any activity on github since April 16 2021, and I haven't seen any other activity elsewhere on other sites. The changes in the fork are required for a clinical organization, who uses conda/bioconda as part of a reproducible build system. I have another clinical client that uses it as well (and is lucky to have chr prefixes; see below). Furthermore, I am re-implementing the software (from Python/C++ into rust, see first PR). This includes unit tests (none in the original) that have already found bugs/issues. Yes, forks are not ideal, but in this case, the fact that bugs like this one make the original software unusable for genomes that have no |
@BiocondaBot please merge |
I will attempt to upload artifacts and merge this PR. This may take some time, please have patience. |
@nh13 thanks for all the context. Fully agreed with your position, and definitely sounds like the tool (and reimplementation) is in the right hands now! |
@daler thank-you! |
Merge PR bioconda#35843, commits were: * fixes * Add new recipe mantis-msi2 This is a fork of mantis-msi, as the latter version is no longer being maintained. mantis-msi2 includes fixes.
This is a fork of mantis-msi, as the latter version is no longer being maintained.
mantis-msi2
includes fixes.Please read the guidelines for Bioconda recipes before opening a pull request (PR).
@BiocondaBot please add label
command.@bioconda/core
in a comment.Please use the following BiocondaBot commands:
Everyone has access to the following BiocondaBot commands, which can be given in a comment:
@BiocondaBot please update
@BiocondaBot please add label
please review & merge
label.@BiocondaBot please fetch artifacts
You can use this to test packages locally.
For members of the Bioconda project, the following command is also available:
@BiocondaBot please merge
Someone must approve a PR first!
This reduces CI build time by reusing built artifacts.
Also, the bot watches for comments from non-members that include
@bioconda/<team>
and will automatically re-post them to notify the addressed<team>
.