Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new recipe mantis-msi2 #35843

Merged
merged 2 commits into from
Jul 19, 2022
Merged

Add new recipe mantis-msi2 #35843

merged 2 commits into from
Jul 19, 2022

Conversation

nh13
Copy link
Member

@nh13 nh13 commented Jul 14, 2022

This is a fork of mantis-msi, as the latter version is no longer being maintained.

mantis-msi2 includes fixes.


Please read the guidelines for Bioconda recipes before opening a pull request (PR).

  • If this PR adds or updates a recipe, use "Add" or "Update" appropriately as the first word in its title.
  • New recipes not directly relevant to the biological sciences need to be submitted to the conda-forge channel instead of Bioconda.
  • PRs require reviews prior to being merged. Once your PR is passing tests and ready to be merged, please issue the @BiocondaBot please add label command.
  • Please post questions on Gitter or ping @bioconda/core in a comment.
Please use the following BiocondaBot commands:

Everyone has access to the following BiocondaBot commands, which can be given in a comment:

@BiocondaBot please update Merge the master branch into a PR.
@BiocondaBot please add label Add the please review & merge label.
@BiocondaBot please fetch artifacts Post links to CI-built packages/containers.
You can use this to test packages locally.

For members of the Bioconda project, the following command is also available:

@BiocondaBot please merge Upload built packages/containers and merge a PR.
Someone must approve a PR first!
This reduces CI build time by reusing built artifacts.

Also, the bot watches for comments from non-members that include @bioconda/<team> and will automatically re-post them to notify the addressed <team>.

nh13 added 2 commits July 14, 2022 10:50
This is a fork of mantis-msi, as the latter version is no longer being maintained.

mantis-msi2 includes fixes.
@nh13 nh13 marked this pull request as ready for review July 14, 2022 19:16
@nh13
Copy link
Member Author

nh13 commented Jul 14, 2022

@BiocondaBot please fetch artifacts

@BiocondaBot
Copy link
Collaborator

Package(s) built on Azure are ready for inspection:

Arch Package Zip File
linux-64 mantis-msi2-2.0.0-h9f5acd7_0.tar.bz2 LinuxArtifacts
osx-64 mantis-msi2-2.0.0-hcd10b59_0.tar.bz2 OSXArtifacts

You may also use conda to install these after downloading and extracting the appropriate zip file. From the LinuxArtifacts or OSXArtifacts directories:

conda install -c packages <package name>

Docker image(s) built (images are in the LinuxArtifacts zip file above):

Package Tag Install with docker
mantis-msi2 2.0.0--h9f5acd7_0
showgzip -dc LinuxArtifacts/images/mantis-msi2:2.0.0--h9f5acd7_0.tar.gz | docker load

@nh13
Copy link
Member Author

nh13 commented Jul 14, 2022

@BiocondaBot please add label

@BiocondaBot BiocondaBot added the please review & merge set to ask for merge label Jul 14, 2022
@nh13
Copy link
Member Author

nh13 commented Jul 14, 2022

Verified the OSX artifacts works for me locally

@daler
Copy link
Member

daler commented Jul 19, 2022

@nh13 is upstream just not taking PRs or something? Or have the original authors documented that they will not maintain? The reason I as is that the changes in the fork seem pretty minor such that they could easily be incorporated to the original, which would save a little maintenance burden in bioconda and would be less confusing to users.

@nh13
Copy link
Member Author

nh13 commented Jul 19, 2022

@daler The original authors have not documented that they will not maintain. However, the upstream hasn't accepted a PR since Jan 23 2020, with the last response on a comment since Nov 6 2020. The person who merged that PR and made that last comment (rbonneville) hasn't had any activity on github since April 16 2021, and I haven't seen any other activity elsewhere on other sites.

The changes in the fork are required for a clinical organization, who uses conda/bioconda as part of a reproducible build system. I have another clinical client that uses it as well (and is lucky to have chr prefixes; see below). Furthermore, I am re-implementing the software (from Python/C++ into rust, see first PR). This includes unit tests (none in the original) that have already found bugs/issues.

Yes, forks are not ideal, but in this case, the fact that bugs like this one make the original software unusable for genomes that have no chr prefix. I am totally open to forks not being accepted as easily as new software, but in this case I don't see an alternative versus having to maintain and install the software separately from bioconda. Thoughts?

@dpryan79
Copy link
Contributor

@BiocondaBot please merge

@BiocondaBot
Copy link
Collaborator

I will attempt to upload artifacts and merge this PR. This may take some time, please have patience.

@BiocondaBot BiocondaBot merged commit 676963b into master Jul 19, 2022
@BiocondaBot BiocondaBot deleted the recipe/mantis-msi2 branch July 19, 2022 18:11
@daler
Copy link
Member

daler commented Jul 19, 2022

@nh13 thanks for all the context. Fully agreed with your position, and definitely sounds like the tool (and reimplementation) is in the right hands now!

@nh13
Copy link
Member Author

nh13 commented Jul 19, 2022

@daler thank-you!

jpfeuffer pushed a commit to OpenMS/bioconda-recipes that referenced this pull request Sep 7, 2022
Merge PR bioconda#35843, commits were: 
 * fixes
 * Add new recipe mantis-msi2

This is a fork of mantis-msi, as the latter version is no longer being maintained.

mantis-msi2 includes fixes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
please review & merge set to ask for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants