Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This is a repository to support a fork of blasr code, renamed to blasrmc for name conflict. It is immediately legacy. #14445

Closed
wants to merge 1 commit into from

Conversation

mchaisso
Copy link
Contributor

new file:   blasr-mc/build.sh
new file:   blasr-mc/meta.yaml

ℹ️
Bioconda has finished the GCC7 migration. If you are dealing with C/C++ or Python package it can be that you need to rebuild other dependent packages. Bioconda utils - update-pinning will assist you with that. If you have any questions please use issue 13578.


  • [ x] I have read the guidelines for bioconda recipes.
  • [ x] This PR adds a new recipe.
  • [ x] AFAIK, this recipe is directly relevant to the biological sciences (otherwise, please submit to the more general purpose conda-forge channel).
  • This PR updates an existing recipe.
  • This PR does something else (explain below).

	new file:   blasr-mc/build.sh
	new file:   blasr-mc/meta.yaml
@mchaisso
Copy link
Contributor Author

@bioconda/core when this finishes bioconda-test, can this PR be reviewed? It is my first bioconda PR.

Copy link
Member

@bgruening bgruening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mchaisso if this package is not meant to be used and obsolete maybe a private channel would be better than bioconda?

- {{ compiler('cxx') }}
host:
- hdf5 <1.8.19x
- libstdcxx-ng
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not needed, imho

md5: c2a3a1a4083ca0355c1603fb1fb3be15

build:
number: 1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

start with 0

- libstdcxx-ng

run:
- hdf5 <1.8.19x
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a comment why this pinning is needed?

about:
home: https://github.com/mchaisson/blasr
license: GNU General Public License v3 (GPLv3)
summary: 'This is a fork of the original PacBio blasr, renamed blasrmc to avoid naming conflicts.'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add why this fork is needed and what are the special features?

@@ -0,0 +1,32 @@
package:
name: blasr-mc
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the binary is called blasrmc without a dash, is this correct?


# HDF5 doesn't have pkgconfig files yet
export CPPFLAGS="-isystem ${PREFIX}/include "
export CPPOPTS="-std=c++98"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here you use c++98 but below c++11



about:
home: https://github.com/mchaisson/blasr
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mchaisso
Copy link
Contributor Author

mchaisso commented Apr 14, 2019 via email

@daler
Copy link
Member

daler commented Jun 23, 2024

Closing due to inactivity, please re-open if needed.

@daler daler closed this Jun 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants