Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plan for the GCC7 migration #13155

Closed
5 of 7 tasks
bgruening opened this issue Jan 21, 2019 · 14 comments
Closed
5 of 7 tasks

plan for the GCC7 migration #13155

bgruening opened this issue Jan 21, 2019 · 14 comments

Comments

@bgruening
Copy link
Member

bgruening commented Jan 21, 2019

  • label all main packages with an additional label (as conda-forge)
  • merge bulk into master
  • add main label to all packages with a gcc7 label
  • communicate clearly to our community that now everything gets (re)build against gcc7
  • communicate that we need to bump the build-number to all packages (and its dependents) if you want to have a rebuild (https://bioconda.github.io/updating.html#updating-recipes-for-a-pinning-change)
  • create a bot to assist users to bump builds, potentially in a single-issue
  • make the bot smart enough to (re)build packages it pinning are bumped globally
bgruening pushed a commit that referenced this issue Jan 22, 2019
* [x] I have read the [guidelines for bioconda recipes](https://bioconda.github.io/guidelines.html).
* [x] This PR adds a new recipe.
* [ ] AFAIK, this recipe **is directly relevant to the biological sciences** (otherwise, please submit to the more general purpose [conda-forge channel](https://conda-forge.org/docs/)).
* [x] This PR updates an existing recipe.
* [x] This PR does something else (explain below).

@bgruening @epruesse @daler As discussed in our meeting, this will bring all of the `bulk` changes in recipes and the blacklist into the `master` branch. No CI changes are being copied over.

Xref #13155
@dpryan79 dpryan79 pinned this issue Jan 22, 2019
@bgruening
Copy link
Member Author

bgruening commented Feb 2, 2019

Thanks to @dpryan79 we have now https://bioconda.github.io/updating.html#updating-recipes-for-a-pinning-change ... the bot is in progress by @epruesse. That leaves us to the point of how we communicate this to all users.

Creating a new issue and ping /all/?

@bgruening
Copy link
Member Author

I added an issue (#13578) and update the PR template (#13579) to reach more people.

@kyleabeauchamp
Copy link
Contributor

kyleabeauchamp commented Feb 10, 2019 via email

@epruesse
Copy link
Member

You can already start bumping. That's actually what the new bioconda-utils update-pinning command does - you hand it packages of interest and it'll bump the dependency chain as necessary.

@epruesse
Copy link
Member

@bgruening - Does this mean I can restart autobump now?

@bgruening
Copy link
Member Author

@epruesse if autobump also considers update-pinning then yes.

Let's wait for @dpryan79 to confirm and feel free to merge #13579 so we update our users.

@kyleabeauchamp: unrelated but could you add run_exports to htslib. I think this would help a lot. Would be great if we could use run_exports more in our stack.

@kyleabeauchamp
Copy link
Contributor

kyleabeauchamp commented Feb 10, 2019 via email

@dpryan79
Copy link
Contributor

Go for it, no need to wait for me!

@kyleabeauchamp
Copy link
Contributor

I ran the update-pinning script and I get a lot of errors:

bioconda-utils update-pinning --bump-only-python recipes/ config.yml --packages deeptools
[...]

Attempting to finalize metadata for pysam
Solving environment: ...working... done
Solving environment: ...working... failed
Unsatisfiable dependencies for platform linux-64: {'bcftools==1.3.1', 'samtools==1.3.1', 'htslib==1.3.1'}

Packages requiring the following:
  No build number change needed: 12
  A rebuild for a new python version: 0
  A build number increment: 0
6 packages produced an error in conda-build: ['recipes/pysam/0.9.1', 'recipes/bcftools', 'recipes/samtools', 'recipes/pysam', 'recipes/htslib', 'recipes/pysam/0.10.0']

I also tried with --bump-only-python and got similar results. Not sure what to make of it, but I thought I'd post because I imagine others will see similar.

@kyleabeauchamp
Copy link
Contributor

Regarding run_exports, I've made a WIP PR (#13586, not sure what else needs to be done.

@epruesse
Copy link
Member

epruesse commented Feb 11, 2019

@kyleabeauchamp It works for me. Could be something with your conda setup. It does say you're in the clear for deeptools though.

@dpryan79
Copy link
Contributor

@kyleabeauchamp I already rebuilt deepTools, pysam (the most recent version), and everything related to samtools/htslib. What you're seeing is due to old pysam versions depending on samtools/htslib versions that are no longer maintained in bioconda (1.3 in particular). We should really go through and see which pysam versions are still required by packages and blacklist/remove those that aren't being actively used. We can add samtools 1.3 back in if it's actually needed of course.

@epruesse
Copy link
Member

@dpryan79 packages or recipes? I assume we only need to maintain recipes building old versions to satisfy pinnings by extant recipe versions, right?

@dpryan79
Copy link
Contributor

@epruesse If there's no linking going on then we only care about packages. Pysam happens to link to htslib, though. However it's in C and not C++, so you're a better judge of whether that's an actual issue than me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants