ARB: Pin glib (#11782)

* Pin glib

* Update meta.yaml

* Update meta.yaml

* Work around CB3 issues

* Work around bioconda-utils lint false positive

* Disable lint check should_not_be_noarch

* Can't reference other packages built in recipe from anything but run

* Move perl to host section. Maybe that helps.

* constraining interpreter version breaks with CB3?

* disable perl version constraint :(

recipes/arb-bio/meta.yaml

@@ -25,12 +25,16 @@ source:
     - gsed.patch
 
 build:
-  number: 4
+  number: 5
+# constraining to perl >= 5.23 does not work via requirements, resulting in a 
+# broken build string. constraining via skip also doesn't work - the suggested
+# approach leads to str < int compare failure during lint. 
+# => let's just hope no one tries building this with an old perl.
+#  skip: True  # [perl <5.23]
 
 requirements:
   build:
     - {{ compiler('cxx') }}
-    - {{ compiler('c') }}
     - pkg-config
     - time
     - lynx
@@ -51,34 +55,13 @@ requirements:
     - libxslt
     - libpng
     - xerces-c
-    - perl >=5.23
-  run:
-    # libs:
-    - openmotif
-    - glib
-    - gettext
-    - xorg-libxi
-    - xorg-libxmu
-    - xorg-libxp
-    - xorg-libxaw
-    - xorg-libxpm
-    - xorg-libxft
-    - libpng
-    # tools:
-    - gnuplot
-    - muscle
-    - mafft
-    - raxml
-    - mrbayes
-    - phylip
-    - phyml 3.2.0*
-    - fasttree
-    - sed >=4.4
-    - xfig
-    - fig2dev
-    # We build a binary perl module. ABI compatability seems to be maintained
-    # at minor version (5.26.x), so we pin accordingly:
-    - {{ pin_compatible("perl", min_pin="x.x", max_pin="x.x") }}
+    # Perl is a problem. We must always have a perl version that was compiled with the
+    # same compiler we are using. Otherwise we run into e.g. "-fstack-protector-strong" type
+    # issues. Make-Maker uses the flags from the perl build time for the makefile it generates,
+    # so those flags must work for us as well.
+    - perl
+
+
 test:
   requires:
     - conda
@@ -93,27 +76,107 @@ outputs:
   - name: libarbdb
     script: install_libarbdb.sh
     requirements:
-      run:
+      build:
+        - {{ compiler('cxx') }}
+      host:
         - glib
+        # We must have perl in the host sections of all output packages because
+        # `pin_compatible` will fail otherwise. Probably another bug.
+        - perl
+      run:
         - gettext
+        - {{ pin_compatible("glib", max_pin="x") }}
+    build:
+      run_exports:
+        - {{ pin_subpackage("libarbdb", exact=True) }}
   - name: arb-bio-tools
     script: install_tools.sh
     requirements:
+      build:
+        - {{ compiler('cxx') }}
+      host:
+        - glib
+        - perl # see above
       run:
-        - {{ pin_subpackage('libarbdb', exact=True) }}
+        - {{ pin_subpackage("libarbdb", exact=True) }}
+
   - name: arb-bio
     script: install_main.sh
     requirements:
+      # We have to restate everything we used above in the top level requirements here.
+      # Lacking proper documentation of anything in conda build 3, all of this is trial
+      # and error. The run dependencies stated at the top level are not applied to the
+      # arb-bio output even though it shares the name with the toplevel.
+      # We also can't use YAML anchors to reference what we wrote above because conda
+      # build breaks YAML by parsing the outputs section again at a later point.
+      # Horrible mess....
+      build:
+        - {{ compiler('cxx') }}
+        - pkg-config
+        - time
+        - lynx
+        - xorg-makedepend
+        - sed >=4.4
+        - tar
+      host:
+        - openmotif-dev
+        - glib
+        - gettext
+        - pthread-stubs
+        - xorg-libxi
+        - xorg-libxp
+        - xorg-libxaw
+        - xorg-libxpm
+        - xorg-libxmu
+        - libtiff
+        - libxslt
+        - libpng
+        - xerces-c
+        - perl
       run:
         - {{ pin_subpackage('arb-bio-tools', exact=True) }}
+        # We build a binary perl module. ABI compatability seems to be maintained
+        # at minor version (5.26.x), so we pin accordingly:
+        - {{ pin_compatible("perl", max_pin="x.x") }}
+        - gettext
+        - openmotif
+        - xorg-libxi
+        - xorg-libxmu
+        - xorg-libxp
+        - xorg-libxaw
+        - xorg-libxpm
+        - xorg-libxft
+        - xorg-libxt
+        - libpng
+        # tools:
+        - gnuplot
+        - muscle
+        - mafft
+        - raxml
+        - mrbayes
+        - phylip
+        - phyml 3.2.0*
+        - fasttree
+        - sed >=4.4
+        - xfig
+        - fig2dev
   - name: arb-bio-devel
     script: install_devel.sh
     requirements:
+      build:
+        - {{ compiler('cxx') }}
       run:
         - {{ pin_subpackage('arb-bio', exact=True) }}
+        - openmotif-dev
 
 about:
   home: http://www.arb-home.de
   license: ARB
   licence_file: arb_LICENSE.txt
   summary: ARB 6 Sequence Analysis Suite
+
+extra:
+  recipe-maintainers:
+    - epruesse
+  skip-lints:
+    - should_not_be_noarch  # false positive, `noarch: False` added by CB3 for outputs