Give title to sub-schemas of oneOf for sum types #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maksbotan
force-pushed
the
maksbotan/one-of-title
branch
from
4a2c52b
to
ac63e99
Compare
maksbotan
force-pushed
the
maksbotan/one-of-title
branch
from
ac63e99
to
a8c3312
Compare
dhess
added a commit
to hackworthltd/primer
that referenced
this pull request
Feb 6, 2024
The previous commit bumped the `openapi3` package to version `3.2.4`, which contains this pull request: biocad/openapi3#88 The title of that PR is simply, "Give title to sub-schemas of oneOf for sum types", and that is what has happened here to our golden test output. Unhelpfully, there's no justification for why this change was made, but it looks harmless enough. (This will presumably require a corresponding schema change on the client side, though.) We also bump the PVP for `openapi3` to reflect the new minimum version requirement. Signed-off-by: Drew Hess <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.