Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a new visual Function editor #607

Open
wants to merge 21 commits into
base: master
Choose a base branch
from

Conversation

3top1a
Copy link

@3top1a 3top1a commented Oct 22, 2024

I have implemented a new function editor mirroring the appearance of the tool's summary page.
It is more intuitive, cleaner and visual.
Adding a new item also shows suggested items, determined by EDAM constraints.
The old editor has been retained but hidden in an accordion.

sc biotools
image

This work has been done under ELIXIR-CZ with the supervision of Tomáš Raček (@krab1k).

@magnuspalmblad
Copy link

Nice work!

@krab1k krab1k requested a review from veitveit October 22, 2024 15:01
@veitveit
Copy link
Member

Wow, this is nice! We will look into it.

@anitamnd
Copy link

Hi @3top1a!
Thank you for the great work. Your approach does make function editing more intuitive. The suggested items are also a great improvement.

We have some suggestions:

  • Could you make it so that the old editor appears only on smaller screen size/resolution like those on mobile phones, while the new editor shows up on larger screens?
  • Would it be easy to show tooltips on the EDAM terms in the editor?
  • We would like for the command and note boxes to be a bit smaller, and also emphasize that these are optional fields. I think keeping them both at the bottom would be easier.
  • Can you make the pull request into the develop branch instead of master?

Let me know if this is something you can do. You can also email me at [email protected] if you want to discuss these in more detail.

Thanks again for your input! Looking forward to hearing from you.

@3top1a
Copy link
Author

3top1a commented Oct 30, 2024

Hi @3top1a! Thank you for the great work. Your approach does make function editing more intuitive. The suggested items are also a great improvement.

We have some suggestions:

* Could you make it so that the old editor appears only on smaller screen size/resolution like those on mobile phones, while the new editor shows up on larger screens?

* Would it be easy to show tooltips on the EDAM terms in the editor?

* We would like for the command and note boxes to be a bit smaller, and also emphasize that these are optional fields. I think keeping them both at the bottom would be easier.

* Can you make the pull request into the develop branch instead of master?

Let me know if this is something you can do. You can also email me at [email protected] if you want to discuss these in more detail.

Thanks again for your input! Looking forward to hearing from you.

Hi,

  • This new editor uses the same CSS and HTML as the tool overview, which hides itself on mobile resolutions. Once I make both work on mobile resolutions the old editor will be ready for deprecation.
  • I'm sorry if I don't understand your question, however tooltips containing what? On the overview page the tooltips only show "Tool operation : click to find more tools with this operation.", and I added "Click to remove" tooltips in the editor to reflect their function.
  • Sure, that makes sense, I will do that.
  • develop is three commits behind master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants