Allow use upstream-base-url config for Android app #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This mirrors the logic used for instant notifications in the iOS app: * When a user subscribes to a topic, the app will subscribe to Firebase using sha256(baseUrl + topic). * When a "poll_request" call is received from Firebase, the app will look up the sha256(baseUrl + topic) of all subscriptions in the database and see if the poll_request topic matches that. If it does, it will poll the original server using the stored baseUrl from the subscriptions database.
kruton
force-pushed
the
android_poll_request
branch
from
d1fc271 to
eee093f
Compare
|
@binwiederhier any interest in merging this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mirrors the logic used for instant notifications in the iOS app:
When a user subscribes to a topic, the app will subscribe to Firebase using
sha256(baseUrl + topic).When a "poll_request" call is received from Firebase, the app will look up the
sha256(baseUrl + topic)of all subscriptions in the database and see if thepoll_requesttopic matches that. If it does, it will poll the original server using the stored baseUrl from the subscriptions database.This fixes binwiederhier/ntfy#358