Increase robustness #24
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit overhauls the test quite a bit: - MQTT Hostname and port can be overridden via environment variable - Deprecated reactPHP APIs are updated - reject vs new RejectedPromise - EventLoop\Factory vs Loop::get - Tests assert now that the callback chain is executed with a flag that is checked at the end - All non-returned promises are now terminated with `done()` to make sure that all exceptions are handled/thrown - Removed unused DNS resolver - default loop works out of the box - PHPUnit now forces error_reporting to E_ALL This uncovers an E_DEPRECATED in react/promise (needs to be fixed upstream)
The currently existing E_DEPRECATED in the reactphp Promise code surfaced an
interesting bug: When you run the ReactMqttClient in an environment that e.g.
throws that E_DEPRECATED as an exception `->otherwise` chains may not be
executed, because the promise-callback-chains are not terminated with `done()`.
This can (currently) be simulated by setting an aggressive error-handler in the
testsuite:
```
set_error_handler(function ($_type, $message) {
throw new Error($message);
});
```
Testcase that rely on promise rejections (e.g. test_connect_failure) will hang
until the test times out.
This commit fixes all non-returned callback-chains with a `done()`-termination
as it is best-practice.
|
The fix for the E_DEPRECATED is in this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit tackles issues in the codebase around unterminated promises. Unreturned promises should always be terminated with
done().The MR consists of two commits (each with a descriptive commit message, please read for details):