Merge changes in to support parsing bash scripts #737
Conversation
BolunThompson
force-pushed
the
bash-merge
branch
from
1ae61d4 to
d451f5a
Compare
Signed-off-by: Bolun Thompson <[email protected]>
Signed-off-by: Bolun Thompson <[email protected]>
Signed-off-by: Bolun Thompson <[email protected]>
Signed-off-by: Bolun Thompson <[email protected]>
The bash tests contain scripts which use UTF-8 only characters, but, by default, Python throws an exception when writing non-ASCII characters to a file. Signed-off-by: Bolun Thompson <[email protected]>
Signed-off-by: Bolun Thompson <[email protected]>
Signed-off-by: Bolun Thompson <[email protected]>
Signed-off-by: Bolun Thompson <[email protected]>
|
OS:ubuntu-20.04 |
|
OS:ubuntu-20.04 |
|
Is the failing test case an expected bug? Can I help debug this somehow? If this is the only thing left let's try to clean it up and merge :) |
|
No, unfortunately — I’ll need to look at this a bit more. I think it could
be an issue only with Ubuntu 20.04? It passes on my local Ubuntu 24.04
system.
…On Wed, Feb 5, 2025 at 12:32 PM Konstantinos Kallas < ***@***.***> wrote:
Is the failing test case an expected bug? Can I help debug this somehow?
If this is the only thing left let's try to clean it up and merge :)
—
Reply to this email directly, view it on GitHub
<#737 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AG232OD33VMBKVWVHSWEBYD2OJYNLAVCNFSM6AAAAABTU5QVNSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMZXHE3DEMRQGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Hmmm, I merged the PR that updates Ubuntu to 24 to |
|
OS:ubuntu-20.04 |
|
I merged binpash/annotations#22 so once we bump versions here in theory things should be OK? |
|
OS:ubuntu-20.04 |
|
OS:ubuntu-24.04 |
It is totally unclear to me why :( |
|
I was playing around with it, and it only occurs on Ubuntu 22.04 and before. I think it’s an expansion bug related to different bash versions? It works with “${pattern[*]}”, but not with “${pattern[@]}”. On Feb 7, 2025, at 5:30 PM, Konstantinos Kallas ***@***.***> wrote:
I pushed a new commit to future to fix a deprecated github action (tight-loop test failure).
There also seems to be another syntax warning ("/home/runner/work/pash/pash/compiler/dspash/ir_helper.py:82: SyntaxWarning: invalid escape sequence '\ '")
The hello bash output seems to be different for pash and bash:
Running hello-world-bash.sh...hello-world-bash:23.696
1.286
1c1
< 4176
---
5971257
It is totally unclear to me why :(
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
Or actually, that’s not it — I forgot that ‘*’ is an unsafe character so it just isn’t parallelized (which makes it work, of course). I’ll look at this more soon.On Feb 7, 2025, at 7:15 PM, Bolun Thompson ***@***.***> wrote:I was playing around with it, and it only occurs on Ubuntu 22.04 and before. I think it’s an expansion bug related to different bash versions? It works with “${pattern[*]}”, but not with “${pattern[@]}”. On Feb 7, 2025, at 5:30 PM, Konstantinos Kallas ***@***.***> wrote:
I pushed a new commit to future to fix a deprecated github action (tight-loop test failure).
There also seems to be another syntax warning ("/home/runner/work/pash/pash/compiler/dspash/ir_helper.py:82: SyntaxWarning: invalid escape sequence '\ '")
The hello bash output seems to be different for pash and bash:
Running hello-world-bash.sh...hello-world-bash:23.696
1.286
1c1
< 4176
---
5971257
It is totally unclear to me why :(
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
This just ended up being an environment issue — I’d fixed the bug locally in binpash/sh-expand#11 and forgot to make a new release. |
BolunThompson
force-pushed
the
bash-merge
branch
from
ee74f4e to
d6b6618
Compare
|
OS:ubuntu-24.04 |
|
OS:ubuntu-20.04 |
|
The posix correctness tests fail because of the old (Separately, this action always succeeds because the exit code isn’t captured, so if/when the server comes back online I could add that). |
|
OS:ubuntu-20.04 |
|
OS:ubuntu-24.04 |
|
OS:ubuntu-20.04 |
|
OS:ubuntu-24.04 |
|
OS:ubuntu-20.04 |
|
OS:ubuntu-24.04 |
|
OS:ubuntu-20.04 |
@BolunThompson this machine has been down for a long time, and we used to get a report to assess the results (not all tests pass, but a number of them). I don't think it will get back up soon... |
Code written by @sethsabar. The tests pass with the changes from binpash/shasta#5 and binpash/libbash#1 (CI will fail until those are merged in).