feat: enforce complete PR communication - #4
Merged
Merged
Conversation
Vendor the lalo-admin assessor already proven on mrbeanz-brains, with the same drift pin and live SoT comparison, so firstmate PRs cannot skip the required overview, decision, module-boundary, and validation sections.
Checking out the base branch cannot execute the new checker until it lands, so restore pull_request and assess the proposed head instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CEO overview
What changed technically
Added the proven Lalo/Beanz PR communication checker: vendored assessor, drift pin, workflow, tests, and pull request template. An untouched template no longer satisfies Module-boundary decision. Transient network and 5xx remote source failures fall back to the local pin with a warning. The introducing PR uses pull_request so the new checker can run before it exists on the default branch.
Validation
Module-boundary decision
Not applicable: this is a CI workflow and vendored checker addition; no product module was created, moved, or extracted.
Decision needed
No decision required.
Pipeline
Updates from git push no-mistakes
✅ **intent** - passed
✅ No issues found.
✅ **Rebase** - passed
✅ No issues found.
scripts/pr-communication/check-drift.mjs:90- The required constraint says, "Do not add a forgotten secret that makes drift self-compare," while the accepted fallback is limited to transient network/5xx failures. Here, missing or invalid private-repository credentials produce 401/403/404, butauthFailureis treated like a transient failure and the check exits successfully using the PR-editable vendored file plus PR-editableSOURCE.sha256. A same-repo PR can therefore change both files and still pass wheneverPR_COMMUNICATION_SOT_TOKENis absent or loses access. Fail closed on authentication/not-found responses, reserving local-pin fallback for network, 408/429, and 5xx failures unless remote verification is explicitly disabled by an accepted policy..github/workflows/pr-communication.yml:17- Required real-CI red-then-green proof is incomplete. GitHub PR feat: enforce complete PR communication #4 has only one pr-communication run, which failed with MODULE_NOT_FOUND on the earlier base-branch checkout implementation. Target commit 3de9707 is not yet on the remote PR, and there is no real-CI failure caused by a non-compliant description followed by a passing compliant description. The outer pipeline must push the target, then perform and preserve that description-edit red-then-green sequence.tests/pr-communication.test.shDirect CLI rejection usingPR_TITLE='WIP'and a non-compliantPR_BODYDirect CLI acceptance using a fully compliant CEO overview, validation, module-boundary decision, and decision-needed bodygh-axi run list --repo=bingb0t5/firstmate --workflow pr-communication.yml --limit 20gh-axi run view 32719166367 -R bingb0t5/firstmate --log-failedgit status --shortafter evidence collection✅ **Document** - passed
✅ No issues found.
✅ **Lint** - passed
✅ No issues found.
✅ **Push** - passed
✅ No issues found.