This repository was archived by the owner on Aug 15, 2025. It is now read-only.
Implement support for smallvec #612
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi bincode developers. This is the second in a series of 3 PRs that would allow us to replace our current use of Abomonation with bincode, without a noticeable performance hit. We'd like these to be adopted upstream, and hope they are useful for other users of bincode also.
We use
SmallVecin a number of places in the structures that we serialize, as this gives us a noticeable memory footprint and performance improvement. Rust's orphan rule prevents us from implementing the bincode traits forSmallVecourselves, as it's defined in a different crate. Instead, we propose adding a new optional feature to bincode with implements the traits for that type when enabled. When thesmallvecfeature is specified, bincode additionally provides implementations ofEncodeandDecodeforSmallVec, much like it already does for the standard library types.