Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made the Cow Encode constraints more permissive #524

Merged
merged 3 commits into from
Mar 17, 2022
Merged

Made the Cow Encode constraints more permissive #524

merged 3 commits into from
Mar 17, 2022

Conversation

VictorKoenders
Copy link
Contributor

Closes #523

@VictorKoenders VictorKoenders requested a review from ZoeyR March 15, 2022 13:34
@VictorKoenders VictorKoenders mentioned this pull request Mar 15, 2022
Closed
@codecov
Copy link

codecov bot commented Mar 15, 2022 •
edited
Loading

Codecov Report

Merging #524 (04a0295) into trunk (7ef6fe2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##            trunk     #524   +/-   ##
=======================================
  Coverage   71.08%   71.08%           
=======================================
  Files          47       47           
  Lines        3178     3178           
=======================================
  Hits         2259     2259           
  Misses        919      919
Impacted Files Coverage Δ
src/features/impl_alloc.rs 91.22% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ef6fe2...04a0295. Read the comment docs.

@ajeetdsouza
Copy link
Contributor

I believe Decode has the same issue.

@VictorKoenders
Copy link
Contributor Author

I had just realized this 👍

@VictorKoenders VictorKoenders merged commit dadf335 into trunk Mar 17, 2022
@VictorKoenders VictorKoenders deleted the relaxed_cow_constraints branch March 17, 2022 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZoeyR ZoeyR ZoeyR approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bincode::Encode doesn't work with Cow<'a, str>
3 participants
@VictorKoenders @ajeetdsouza @ZoeyR