Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/improve serde #477

Merged
merged 2 commits into from
Jan 19, 2022
Merged

Feature/improve serde #477

merged 2 commits into from
Jan 19, 2022

Conversation

VictorKoenders
Copy link
Contributor

To be merged after #475

This PR improves serde support for alloc and no_std targets. Until #472 is stabilized, we'll have to make do with this.

I also took the liberty to move all of serde's errors to EncodeError::Serde and DecodeError::Serde, so they don't pollute the main error too much.

src/features/serde/mod.rs Show resolved Hide resolved
src/features/serde/mod.rs Outdated Show resolved Hide resolved
src/features/serde/mod.rs Show resolved Hide resolved
src/features/serde/mod.rs Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Merging #477 (81d5d1c) into trunk (d8ba21a) will decrease coverage by 0.27%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            trunk     #477      +/-   ##
==========================================
- Coverage   66.44%   66.17%   -0.28%     
==========================================
  Files          38       38              
  Lines        2691     2702      +11     
==========================================
  Hits         1788     1788              
- Misses        903      914      +11     
Impacted Files Coverage Δ
src/error.rs 0.00% <ø> (ø)
src/features/serde/de_borrowed.rs 0.00% <0.00%> (ø)
src/features/serde/de_owned.rs 0.00% <0.00%> (ø)
src/features/serde/mod.rs 0.00% <0.00%> (ø)
src/features/serde/ser.rs 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8ba21a...81d5d1c. Read the comment docs.

@VictorKoenders VictorKoenders merged commit 983680c into trunk Jan 19, 2022
@VictorKoenders VictorKoenders deleted the feature/improve_serde branch January 19, 2022 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants