增加 查询红包、拉取订单评价 request入参方式的接口和实现。方便同一wxpayservice实现对接多个appid的支付 #989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
多谢提交PR，不过请移除没有实质性修改的提交，解决下冲突问题，谢谢 |
|
看了你提交的新代码，基本属于拷贝原有方法，能否做优化，比如重用某些代码？ |
|
还有只是对包顺序的代码修改，还是去掉吧，没有意义。 |
|
好的，谢谢 |
|
楼主最近有优化的计划没？没有的话我先合并了，到时候我再适当进行重构 |
|
暂时没有，之前项目急用微信支付就用了这个库，后来需求变更发现这个库在微信支付这块通用性不够强准备优化。但是现在没有那么多时间。谢谢！ |
|
好的，能提交PR已经很不容易了，非常感谢 |
Merged
|
楼主你下次提交代码前记得运行下相关单元测试，不要影响了现有的功能，你的这次修改最近被发现出现bug，请参考相关issue - #1148 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.