Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

修复QrCodeRequestExecutor类MimeType比较的bug #356

Closed
wants to merge 1 commit into from
Closed

修复QrCodeRequestExecutor类MimeType比较的bug #356

wants to merge 1 commit into from

Conversation

yangfjiahl
Copy link

[模块]
[说明]

[需求]update
36fb4ed 
[模块]
[说明]
@binarywang
Copy link
Owner

感谢提交PR，但是有两个问题：
首先请不要提交到master分支，最好先看下贡献指南，
其次不清楚你到底做了什么修改，看起来改了很多东西，也没有个描述性的东西，至少标题里描述下吧？

@binarywang binarywang closed this Oct 18, 2017
@yangfjiahl
Copy link
Author

改了一行代码，因为我ide的格式化工具，所以格式化了很多。
其它pom是我本地临时需要先跑起来，所以换了个版本。
我没用过pr，所以不知道怎么玩：）

QrCodeRequestExecutor, line:51
这行代码在调用出错时，有bug。
原有代码左边是application/json，右边是application/json; charset=utf-8。

@binarywang binarywang changed the title [需求]update 修复QrCodeRequestExecutor类MimeType比较的bug Oct 18, 2017
@binarywang
Copy link
Owner

那我基本明白你的意思了，这个bug可能存在在多处，我稍后直接做个修复提交上来

binarywang added a commit that referenced this pull request Oct 18, 2017
@binarywang
#356 修复QrCodeRequestExecutor类MimeType比较的bug
0f007d9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yangfjiahl @binarywang