This repository has been archived by the owner on Feb 22, 2024. It is now read-only.
kate/78896/ TrackJS: a.markets.forex is undefined #7328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
habib-deriv
approved these changes
Jan 31, 2023
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
maryia-deriv
approved these changes
Jan 31, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue comes from Japan accounts (and only one from Norway):
this.markets(line 126) is an object which has NO forex key, the only available is synthetics (see the screenshot of console in the card). So, the simple check withiffor undefined was implemented.Note 1: I couldn't use optional chaining (
delete this.markets?.forex.submarkets?.smart_fx) because of an error from babel. The option below also couldn't be used, as I got an error from eslint:this.markets.forex && delete this.markets.forex.submarkets.smart_fx;Note 2: In local host there was an error about the missing key in
<React.Fragment>after using map method, so I decided to fix it by adding an index.