Skip to content
This repository has been archived by the owner on Feb 22, 2024. It is now read-only.

Aizad/ Added Goto Deriv Popup for account creation #7324

Merged

Conversation

aizad-deriv
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented Jan 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
binary-static ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 3, 2023 at 2:21PM (UTC)

akmal-deriv
akmal-deriv previously approved these changes Jan 19, 2023
Copy link
Contributor

@akmal-deriv akmal-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hamza-deriv
hamza-deriv previously approved these changes Jan 19, 2023
matin-deriv
matin-deriv previously approved these changes Jan 25, 2023
Copy link
Contributor

@yashim-deriv yashim-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments. The rest are good to go

src/javascript/app/base/header.js Outdated Show resolved Hide resolved
src/javascript/app/base/header.js Outdated Show resolved Hide resolved
yashim-deriv
yashim-deriv previously approved these changes Jan 25, 2023
hamza-deriv
hamza-deriv previously approved these changes Jan 26, 2023
Copy link
Contributor

@habib-deriv habib-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.0% 1.0% Duplication

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants