This repository has been archived by the owner on Feb 22, 2024. It is now read-only.
Ali (Ako)/ Redirect career page to deriv #6468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
April 8, 2021 18:32
…irect-career-page-to-deriv
negarn
reviewed
Apr 14, 2021
scripts/config/pages.js
Outdated
| @@ -80,7 +80,6 @@ module.exports = [ | |||
| ['about-us', 'static/about/index', 'full_width', 'About Us'], | |||
| ['asuncion', 'static/about/asuncion', 'full_width', 'Careers - Asunción'], | |||
| ['binary-in-numbers', 'static/about/binary_in_numbers', 'default', 'Binary.com in Numbers'], | |||
| ['careers', 'static/about/careers', 'full_width', 'Careers'], | |||
There was a problem hiding this comment.
we can't just delete the page. it could be used in marketing emails or other materials. let's keep the url and the page live, just change our links on the site to the deriv careers. we can consider asking devops to redirect binary.com careers page to deriv careers whenever someone lands on the url
negarn
approved these changes
Apr 14, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Career page link redirected to deriv.com/career
Also the old career page of binary deleted.