Skip to content
This repository was archived by the owner on Oct 12, 2022. It is now read-only.

feat: add stylelint#64

Open
resir014 wants to merge 6 commits into
bildpunkt:masterfrom
resir014:feature/58-stylelint
Open

feat: add stylelint#64
resir014 wants to merge 6 commits into
bildpunkt:masterfrom
resir014:feature/58-stylelint

Conversation

@resir014
Copy link
Copy Markdown
Contributor

@resir014 resir014 commented Dec 7, 2017

Description

see #58

this PR adds Stylelint support. SCSS linting is done through npm run lint:css.

Requirements

  • Followed code style

What's to be done

  • add initial Stylelint config
  • configure Webpack + Stylelint

@resir014
Copy link
Copy Markdown
Contributor Author

resir014 commented Dec 13, 2017

Hmph. It appears that adding Stylelint to the webpack setup isn't possible with how electron-vue is set up. Even vuejs-templates/webpack#836 suggests separating the CSS through ExtractTextPlugin, then running stylelint against it. /:

I guess we'll have to figure out Webpack stuff on a separate PR. Do you want me to rearrange the npm tasks to include stylelint as well? @pixeldesu

@pixeldesu
Copy link
Copy Markdown
Member

pixeldesu commented Dec 13, 2017

@resir014 Hmm, looks like it. Leave the npm tasks but get rid of the Webpack stuff then, we'll add that at a later point if ever possible!

(Also, add a task for the --fix flag of stylelint please, just like with ESLint)

We'll explore stylelint + Webpack on a separate PR.
@resir014
Copy link
Copy Markdown
Contributor Author

resir014 commented Dec 15, 2017

Will do.

Also hrm, while running the --fix command I ran into this issue. Will see if the fixes suggested actually works.

Edit: It works, although autofix doesn't seem to work on my end...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants