Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos. #57

Merged
merged 3 commits into from
Aug 29, 2024
Merged

Fix typos. #57

merged 3 commits into from
Aug 29, 2024

Conversation

geoffrey-eisenbarth
Copy link
Sponsor Collaborator

I also discovered that there's a clash between --main-font and --primary-font, where

  1. src/main.css
  2. src/variables.css
  3. www/docs/60-variables.md
  4. www/_includes/layout.vto

use --main-font (and --secondary-font), and

  1. src/utils.css
  2. www/docs/80-utils.md

use --primary-font.

This change doesn't seem to be documented in any of the www/release/*.md files, like the switch from --display-font to --secondary-font is (and actually, just checking this I see there's still a holdover where www/docs/80-utils.md contains an entry for --display-font).

If someone could advise on whether to use --main-font or --primary-font, I can add those fixes (and the --display-font one) to this PR.

@dz4k
Copy link
Collaborator

dz4k commented Aug 23, 2024

--main-font is the preferred one.

I would like --secondary-font and --display-font to coexist, with --display-font defaulting to var(--secondary-font). --secondary-font would be for UI elements and figure captions, and --display-font for headings.

@dz4k dz4k merged commit 099b90a into bigskysoftware:dev Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants