Generate .d.ts file from the esm module (#2733) #2734
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Telroshan
added
bug
|
Cool, this works. Avoiding more config files is a priority of ours, and I appreciate your flexibility on finding a way forward. |
alexpetros
approved these changes
Jul 26, 2024
jasonrm
reviewed
Jul 28, 2024
There was a problem hiding this comment.
I think files needs to be updated with the new name.
dist/htmx.d.ts -> dist/htmx.esm.d.ts
Alexerson
pushed a commit
to Alexerson/htmx
that referenced
this pull request
Jul 29, 2024
4 tasks
alexpetros
pushed a commit
that referenced
this pull request
Jul 29, 2024
* Generate .d.ts file from the esm module (#2733) * Fix types annotation filename in package.json (#2734) --------- Co-authored-by: Alexandre Spaeth <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Generating the
htmx.d.tsfile fromsrc/htmx.jsmeans theexportstatements are not included in the types file. Because typescript users will always want to import theesmfile, it makes more sense to generate the types file from the module.Corresponding issue: #2733
Testing
After generating the new type definition, I copied the content of
dist/to my local projectnode_modulesand the error disappears and the project builds properly.Checklist
masterfor website changes,devforsource changes)
approved via an issue
npm run test) and verified that it succeeded