Improve head tag parsing on template fragments #2024
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR:
useTemplateFragments
configuration.makeFragment(response)
function as head-support extension already implemented a proper merging algorithm for that.hxboost_partial_template_parsing/index.html, index-partial.html & other-content.html
.Corresponding issue: #2018
This PR needs a review. For knowledge: @1cg @alexpetros
Testing
content = content.replace(regexPatterns.HEAD, '');
Checklist
master
for website changes,dev
forsource changes)
approved via an issue
npm run test
) and verified that it succeeded