-
Notifications
You must be signed in to change notification settings - Fork 377
Eval hackathon #752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eval hackathon #752
Conversation
|
I would have changed "If the original version says" to "If the English version says", and I likewise would be hesitant about alternating between using "passage" vs. "sentence" in the prompt, especially considering e.g. the use of questions in the dataset. But maybe that's too pedantic? |
|
@fyvo there are build errors. Could you merge with |
|
@fyvo could you run the test Merging back the main eval-hackathon branch into this PR won't solve the tests, since it's a GH action limitation (disk space limitation), even though you should do it cause a few things have been updated! If they pass locally, then let's merge this! |
|
@VictorSanh I just ran the test for wmt14/fr-en, the result is in your mailbox |
VictorSanh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @fyvo !
I fixed a small bug in the prompt names
I ran all the tests locally, and they all pass except for wmt17/zh-en, wmt18/zh-en, and wmt19/zh-en, which is not a problem in the prompts but in HF datasets. The prompts lgtm though so still merging
Added prompts for machine translation from WMT 14 en-fr (both directions, so these are two separate tasks, the prompt name tells the direction). Templates are close to ones used in GPT-3 and T5 papers. Most prompts come in two flavours: the source language is either explicit or must be inferred. One prompt is also translated in French. WMT14 datasets are in Huggingface Datasets but are unavailable from the promptsource interface. The filter_english_datasets method in utils.py had to be locally modified to include these (huge) datasets.