Skip to content

[testing] fixes for pt-1.10 #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jaketae merged 2 commits into from
Aug 21, 2021
Merged

[testing] fixes for pt-1.10 #71

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6df786d
fixes for pt-1.10
stas00 Aug 21, 2021
534b974
switch to torch_assert_equal wrapper
stas00 Aug 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions megatron/testing_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,6 +207,10 @@ def get_gpu_count():
else:
return 0

def torch_assert_equal(actual, expected):
""" emulates the removed torch.testing.assert_equal """
torch.testing.assert_close(actual, expected, rtol=0.0, atol=0.0)


def get_tests_dir(append_path=None):
"""
Expand Down
10 changes: 5 additions & 5 deletions tests/test_activations.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
from torch.nn import functional as F

from megatron.model.activations import liglu, geglu, reglu, swiglu
from megatron.testing_utils import set_seed
from megatron.testing_utils import set_seed, torch_assert_equal


class TestActivations(unittest.TestCase):
Expand All @@ -27,16 +27,16 @@ def test_shapes(self):

def test_liglu(self):
expected = self.x1 * self.x2
torch.testing.assert_equal(liglu(self.x), expected)
torch_assert_equal(liglu(self.x), expected)

def test_geglu(self):
expected = self.x1 * F.gelu(self.x2)
torch.testing.assert_equal(geglu(self.x), expected)
torch_assert_equal(geglu(self.x), expected)

def test_reglu(self):
expected = self.x1 * F.relu(self.x2)
torch.testing.assert_equal(reglu(self.x), expected)
torch_assert_equal(reglu(self.x), expected)

def test_swiglu(self):
expected = self.x1 * F.silu(self.x2)
torch.testing.assert_equal(swiglu(self.x), expected)
torch_assert_equal(swiglu(self.x), expected)