urgent fix: exclusive scan computing pointers list #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
|
Member
|
I've added a test in order to maintain stability with microsoft/Megatron-DeepSpeed: I checked that commit previous to this PR fails the test, and following that PR checks. Maybe we want to have a smaller dataset than openwebtext. I'm currently using this as it was the easiest to work with. cc @stas00 |
Contributor
Author
|
Thank you, @thomasw21 ! |
thomasw21
referenced
this pull request
Aug 20, 2021
- Add a test to stability compared to official repo.
adammoody
pushed a commit
to adammoody/Megatron-DeepSpeed
that referenced
this pull request
Oct 27, 2022
* Enable Megatron-LM workload on ROCm (#1) * Enable Megatron workload on ROCm * Added ds_pretrain_gpt_350M_dense_pipeclean.sh * removed a file * Removed an extra line * Fix to resolve the below rsqrtf() error on ROCm /root/Megatron-DeepSpeed/megatron/fused_kernels/layer_norm_hip_kernel.hip:298:10: error: no matching function for call to 'rsqrtf' return rsqrtf(v); ^~~~~~ /opt/rocm-5.2.0/llvm/lib/clang/14.0.0/include/__clang_hip_math.h:521:7: note: candidate function not viable: call to __device__ function from __host__ function float rsqrtf(float __x) { return __ocml_rsqrt_f32(__x); } ^ * Simplified code * Simplified the code * Removed extra spaces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@stas00 and @thomasw21 , I introduced a bug while computing the pointers list with the switch to use numpy. This fixes that.
Before submitting that previous PR, I remember double checking the resulting index files with
cmp. I must have mistakenly checked two files that were both produced with the incorrect code.So any mmap files produced since merging that last PR will have bad data. Sorry about that!