-
Notifications
You must be signed in to change notification settings - Fork 228
Update requirements.txt #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Small question, can we specify version? |
|
@thomasw21 We could, and we probably should. I just wasn't sure which version people are using for their dev environment. Here's what |
stas00
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @jaketae
With one correction
|
I don't think hardcoded versions are a great idea unless you know you really need a specific version. Otherwise you run into conflicts with other projects and necessitate a requirement for a dedicated conda env just for this repo. So my vote is no hardcoded versions unless it's needed. Specifying In general, when in doubt see how HF |
I don't know on top of my head if there is a specific package version we need (other than the branch of |
README already specifies this in greater detail.
This PR adds two more dependencies (
transformers,deepspeed) torequirements.txtthat are needed to install this repository.