Skip to content

[dataset merge] fix timing #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
stas00 merged 1 commit into from
Jul 28, 2021
Merged

[dataset merge] fix timing #31

stas00 merged 1 commit into from
Jul 28, 2021

Conversation

@stas00
Copy link
Contributor

@stas00 stas00 commented Jul 28, 2021

indices merge takes much longer than the concat of data, so moving the end timer to the end.

@stas00 stas00 requested a review from thomasw21 July 28, 2021 16:48
thomasw21
thomasw21 approved these changes Jul 28, 2021
View reviewed changes
Copy link
Member

@thomasw21 thomasw21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stas00 stas00 merged commit feca57a into bigscience-workshop:main Jul 28, 2021
@stas00 stas00 deleted the preprocess-merge-fix branch July 28, 2021 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thomasw21 thomasw21 thomasw21 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@stas00 @thomasw21