Curriculum learning support #132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stas00
suggested changes
Oct 9, 2021
Contributor
stas00
left a comment
stas00
left a comment
There was a problem hiding this comment.
Thank you, @conglongli!
I added a few suggestions to the tutorial's wording and one question.
Next to testing it out.
stas00
reviewed
Oct 9, 2021
Co-authored-by: Stas Bekman <stas00@users.noreply.github.com>
stas00
reviewed
Oct 9, 2021
Contributor
|
Added a failing test, but can't push into this PR, since your branch doesn't allow maintainer edit. |
stas00
reviewed
Oct 9, 2021
Co-authored-by: Stas Bekman <stas00@users.noreply.github.com>
stas00
reviewed
Oct 9, 2021
Contributor
stas00
left a comment
stas00
left a comment
There was a problem hiding this comment.
Just trying to make the code easier to grasp faster
Co-authored-by: Stas Bekman <stas00@users.noreply.github.com>
Co-authored-by: Stas Bekman <stas00@users.noreply.github.com>
stas00
approved these changes
Oct 9, 2021
Contributor
stas00
left a comment
stas00
left a comment
There was a problem hiding this comment.
All is now working, but need to wait for deepspeedai/DeepSpeed#1443 to be merged before we can merge this.
Thank you, @conglongli
Contributor
|
CI seems to check out main branch's head, which is absolutely wrong. CI really needs some attention. But the tests pass, so merging this. |
thomasw21
reviewed
Oct 20, 2021
adammoody
pushed a commit
to adammoody/Megatron-DeepSpeed
that referenced
this pull request
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CL integration for big science project. Currently only integrated for GPT pre-training. Includes an example train script and a tutorial. Before merge need @stas00 to test it on real big science experiments, also probably need @ShadenSmith 's code review since there are some changes related to DeepSpeed pipeline parallelism support.
Corresponding changes needed on DS side: deepspeedai/DeepSpeed#1440
Blocking event: