Skip to content

[tensor comparisons] support pt-1.8, add torch_assert_close #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stas00 merged 1 commit into from
Sep 16, 2021
Merged

[tensor comparisons] support pt-1.8, add torch_assert_close #106

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions megatron/testing_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,9 +208,20 @@ def get_gpu_count():
else:
return 0

def torch_assert_equal(actual, expected):
""" emulates the removed torch.testing.assert_equal """
torch.testing.assert_close(actual, expected, rtol=0.0, atol=0.0)
def torch_assert_equal(actual, expected, **kwargs):
# assert_equal was added around pt-1.9, it does better checks - e.g will check dimensions match
if hasattr(torch.testing, "assert_equal"):
return torch.testing.assert_equal(actual, expected, **kwargs)
else:
return torch.allclose(actual, expected, rtol=0.0, atol=0.0)

def torch_assert_close(actual, expected, **kwargs):
# assert_close was added around pt-1.9, it does better checks - e.g will check dimensions match
if hasattr(torch.testing, "assert_close"):
return torch.testing.assert_close(actual, expected, **kwargs)
else:
kwargs.pop("msg", None) # doesn't have msg arg
return torch.allclose(actual, expected, **kwargs)


def is_torch_bf16_available():
Expand Down