refactor: STRF-8599 Renamed ex-jquery "on" method to subscribe #131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Autotagging @bigcommerce/storefront-team |
junedkazi
reviewed
Sep 1, 2020
|
|
||
| export default class extends EventEmitter { | ||
| on(eventName, elementSelector, handler) { | ||
| subscribe(eventName, elementSelector, handler) { |
Contributor
There was a problem hiding this comment.
Why are we making this change ? Is there some kind of name collusion?
Contributor
Author
There was a problem hiding this comment.
Yep, that's why some tests were failing on cornerstone. EventEmitter has method with name on
junedkazi
approved these changes
Sep 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.