Micro-optimisation in BindingClosureFactory: speed up injector invocation and proxy closures #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What/Why?
Micro-optimisation in BindingClosureFactory: speed up injector invocation and proxy closures. Replace call_user_func_array with direct call + splat in Injector::invoke.
Based on benchmarks on my laptop, this will save approx 7.5 µs per request (assuming 300 invocations). Not spectacular (I had hoped for more) but since the work is already done, I'd like to move forward with it.
Rollout/Rollback
Merge / revert
Testing
Tests cover all of this already, and they still pass