Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support newer versions of firebase/php-jwt #208

Merged
merged 2 commits into from
Aug 22, 2017
Merged

Conversation

BVMiko
Copy link
Contributor

@BVMiko BVMiko commented Aug 17, 2017

After some testing, this package seems to work fine with PHP-JWT v5.0.

@lord2800
Copy link
Contributor

I don't suppose you happen to have a link to the changelog handy?

@BVMiko
Copy link
Contributor Author

BVMiko commented Aug 17, 2017

PHP-JWT Changelog:

5.0.0 / 2017-06-26

4.0.0 / 2016-07-17

  • Add support for late static binding. See #88 for details. Thanks to @chappy84!
  • Use static $timestamp instead of time() to improve unit testing. See #93 for details. Thanks to @josephmcdermott!
  • Fixes to exceptions classes. See #81 for details. Thanks to @Maks3w!
  • Fixes to PHPDoc. See #76 for details. Thanks to @akeeman!

@coveralls
Copy link

coveralls commented Aug 17, 2017

Coverage Status

Coverage decreased (-0.1%) to 69.048% when pulling 9b942ac on BVMiko:master into 01a42fe on bigcommerce:master.

Copy link
Contributor

@lord2800 lord2800 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'll see about getting this merged!

@zvuki zvuki merged commit e57fc7a into bigcommerce:master Aug 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants