Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NCLX color profile rework #66

Merged
merged 3 commits into from
Dec 28, 2022
Merged

NCLX color profile rework #66

merged 3 commits into from
Dec 28, 2022

Conversation

bigcat88
Copy link
Owner

Fixes #64 .

Changes proposed in this pull request:

  • Adds support for read nclx values
  • Fixes memory leak
  • NCLX write is still partial(it will be necoded in image itself, and libheif can't read that afterwards) due to libheif restrictions

@codecov
Copy link

codecov bot commented Dec 27, 2022

Codecov Report

Merging #66 (1388fd0) into master (e865a21) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master       #66   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           13        13           
  Lines         1077      1088   +11     
=========================================
+ Hits          1077      1088   +11     
Impacted Files Coverage Δ
pillow_heif/private.py 100.00% <100.00%> (ø)

@bigcat88 bigcat88 merged commit 00c0d8e into master Dec 28, 2022
@bigcat88 bigcat88 deleted the nclx-profile branch December 28, 2022 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Small memory leak when opening image with nclx color profile
1 participant