Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update Docker Build-Push Action and Add ARM64 Support #412

Merged
merged 5 commits into from
Apr 23, 2024

Conversation

cloudsbird
Copy link
Contributor

@cloudsbird cloudsbird commented Apr 20, 2024

Issues: #296
This pull request introduces two significant changes to our Docker build and push workflow:

Update:

  • Docker Build-Push Action Version: The version of docker/build-push-action has been updated from v2 to v5.
  • Add ARM64 Platform Support: Previously, our Docker images were only built for the linux/amd64 platform. With this update, we are adding support for the linux/arm64 platform.
  • Docker Login Action Version : The version of docker/login-action has been updated from v1 to v3

References:
https://docs.docker.com/build/ci/github-actions/multi-platform/

Copy link

vercel bot commented Apr 20, 2024

@cloudsbird is attempting to deploy a commit to the Bigcapital Team on Vercel.

A member of the Team first needs to authorize it.

@abouolia
Copy link
Contributor

Awesome stuff, will review it before EOD. @cloudsbird

Copy link
Contributor

@abouolia abouolia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is perfect.

@abouolia abouolia changed the title Update Docker Build-Push Action and Add ARM64 Support feat: Update Docker Build-Push Action and Add ARM64 Support Apr 23, 2024
@abouolia abouolia merged commit 46639c7 into bigcapitalhq:develop Apr 23, 2024
1 check failed
@abouolia
Copy link
Contributor

@cloudsbird Really appreciate your contribution, one of the things we wanted to add to this GH action, pushing Docker containers by version tag instead of latest to keep all versions in the Docker registry and make it easy to users to rollback to the previous versions. @all-contributors please add @cloudsbird code

@abouolia
Copy link
Contributor

@all-contributors please add @cloudsbird code

Copy link
Contributor

@abouolia

I've put up a pull request to add @cloudsbird! 🎉

@cloudsbird
Copy link
Contributor Author

cloudsbird commented Apr 24, 2024

hi @abouolia,
Okay I will create issues for this
here you go #420

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants