Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade tldraw to 1.27.0 to include accessibility improvements #16487

Merged
merged 1 commit into from
Jan 17, 2023

Conversation

antobinary
Copy link
Member

What does this PR do?

Upgrades tldraw to 1.27.0 to include accessibility improvements

Closes Issue(s)

Closes #16147

Motivation

Upgrading tldraw to include changes made in tldraw/tldraw#1106 and tldraw/tldraw#1095

@antobinary antobinary added this to the Release 2.6 milestone Jan 17, 2023
@antobinary
Copy link
Member Author

P.S. I spot one more familiar name in the this tldraw release! tldraw/tldraw#1104 Nice job @hiroshisuga !! 😺

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
1.3% 1.3% Duplication

@padaliyajay
Copy link

I want to modify tldraw 1.27.0. but there is no tag existing of 1.27.0 version. how did you found this version?

@antobinary
Copy link
Member Author

There was such a tag back then. Since then the tldraw v1 project was renamed and archived (without tags) and moved to this other repository: https://github.com/tldraw/tldraw-v1
What remains in tldraw/tldraw is v2 which we use on BBB 3.0, but be careful as the license of tldraw v2 changes when they were switching from alpha to beta. We use the alpha version.

@padaliyajay
Copy link

padaliyajay commented Jul 4, 2024

Thank you for response. i found it. :)

But there is now only latest version 1.29.2 available in that v1 repo. So if i use that version in bbb v2.7 then will it work or any known issue?

@antobinary
Copy link
Member Author

https://www.npmjs.com/package/@tldraw/tldraw/v/1.27.0

If you're really keen on finding a live repository with 1.27.0, maybe try looking for someone's fork or npmjs packages. Here's one for 1.29 https://www.npmjs.com/package/@gip-recia/tldraw-v1

@antobinary
Copy link
Member Author

To benefit from our testing on BBB 2.7, please use the version we've tagged there: https://github.com/bigbluebutton/bigbluebutton/blob/v2.7.x-release/bigbluebutton-html5/package.json#L42 1.27.0
We have not tested BBB 2.7 with a newer tldraw.

@padaliyajay
Copy link

Thank you. What i want is to decrease stroke width of line. so i want to fork tldraw 1.27 and then modify code and install back to bbb 2.7. But unfortunately source code of v1.27.0 not available anymore. not even in npm. it is compiled code

So i have to use tldraw 1.29

@antobinary
Copy link
Member Author

@padaliyajay try something like this https://github.com/karolstawowski/tldraw/tree/55a8831a6b036faae0dfd77d6733a8f585f5ae23
The commit is for 1.27.0 renaming. It might be a few commits off from the actual release but it's the best I spot at the moment. Fork it and browse locally... Hope it helps!

@padaliyajay
Copy link

@antobinary Thank you so much for finding me repo. But i already tried tldraw 1.29 and it is working without any problems in BBB 2.7. and i also modified it to decreased thickness of line and it is also working. once again thank you so much for help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants